Add # syntax to other source schemes

Author: bcardiff

spec/unit/dependency_definition_spec.cr

@@ -14,13 +14,17 @@ module Shards
 
       # GitHub urls
       expect_parses("https://github.com/foo/bar", "github", "foo/bar", Any)
+      expect_parses("https://github.com/foo/bar#1.2.3", "github", "foo/bar", VersionReq.new("~> 1.2.3"))
 
       # GitHub urls from clone popup
       expect_parses("https://github.com/foo/bar.git", "github", "foo/bar", Any)
+      expect_parses("https://github.com/foo/bar.git#1.2.3", "github", "foo/bar", VersionReq.new("~> 1.2.3"))
       expect_parses("[email protected]:foo/bar.git", "git", "[email protected]:foo/bar.git", Any)
+      expect_parses("[email protected]:foo/bar.git#1.2.3", "git", "[email protected]:foo/bar.git", VersionReq.new("~> 1.2.3"))
 
       # GitLab short syntax
       expect_parses("gitlab:foo/bar", "gitlab", "foo/bar", Any)
+      expect_parses("gitlab:foo/bar#1.2.3", "gitlab", "foo/bar", VersionReq.new("~> 1.2.3"))
 
       # GitLab urls
       expect_parses("https://gitlab.com/foo/bar", "gitlab", "foo/bar", Any)

src/dependency_definition.cr

@@ -2,7 +2,7 @@ require "./dependency"
 
 module Shards
   class DependencyDefinition
-    record Parts, resolver_key : String, source : String, requirement : Requirement = Any
+    record Parts, resolver_key : String, source : String, requirement : Requirement
 
     property dependency : Dependency
     # resolver's key and source are normalized. We preserve the key and source to be used
@@ -47,28 +47,36 @@ module Shards
     def self.parts_from_cli(value : String) : Parts
       uri = URI.parse(value)
 
+      # fragment parsing for version requirement
+      requirement = Any
+      if fragment = uri.fragment
+        uri.fragment = nil
+        value = value.rchop("##{fragment}")
+        requirement = VersionReq.new("~> #{fragment}")
+      end
+
       case scheme = uri.scheme
       when Nil
         case value
         when .starts_with?("./"), .starts_with?("../")
-          Parts.new("path", Path[value].to_posix.to_s)
+          Parts.new("path", Path[value].to_posix.to_s, Any)
         when .starts_with?(".\\"), .starts_with?("..\\")
           {% if flag?(:windows) %}
-            Parts.new("path", Path[value].to_posix.to_s)
+            Parts.new("path", Path[value].to_posix.to_s, Any)
           {% else %}
             raise Shards::Error.new("Invalid dependency format: #{value}")
           {% end %}
         when .starts_with?("git@")
-          Parts.new("git", value)
+          Parts.new("git", value, requirement)
         else
           raise Shards::Error.new("Invalid dependency format: #{value}")
         end
       when "file"
         raise Shards::Error.new("Invalid file URI: #{uri}") if !uri.host.in?(nil, "", "localhost") || uri.port || uri.user
-        Parts.new("path", uri.path)
+        Parts.new("path", uri.path, Any)
       when "https"
         if resolver_key = GitResolver::KNOWN_PROVIDERS[uri.host]?
-          Parts.new(resolver_key, uri.path[1..-1].rchop(".git")) # drop first "/""
+          Parts.new(resolver_key, uri.path[1..-1].rchop(".git"), requirement) # drop first "/""
         else
           raise Shards::Error.new("Cannot determine resolver for HTTPS URI: #{value}")
         end
@@ -79,12 +87,6 @@ module Shards
           if uri.host.nil? || subscheme
             uri.scheme = subscheme
           end
-          # narrow down requirement
-          requirement = Any
-          if version = uri.fragment
-            uri.fragment = nil
-            requirement = VersionReq.new("~> #{version}")
-          end
           return Parts.new(scheme, uri.to_s, requirement)
         end
         raise Shards::Error.new("Invalid dependency format: #{value}")