Fix: remove internal calls to deprecated IO::FileDescriptor#new (blocking arg)

Author: ysbaddaden

src/crystal/event_loop/iocp.cr

@@ -237,9 +237,11 @@ class Crystal::EventLoop::IOCP < Crystal::EventLoop
 
   def pipe(read_blocking : Bool?, write_blocking : Bool?) : {IO::FileDescriptor, IO::FileDescriptor}
     r, w = System::FileDescriptor.system_pipe(!!read_blocking, !!write_blocking)
+    create_completion_port(r) unless read_blocking
+    create_completion_port(w) unless write_blocking
     {
-      IO::FileDescriptor.new(r, !!read_blocking),
-      IO::FileDescriptor.new(w, !!write_blocking),
+      IO::FileDescriptor.new(handle: r, blocking: !!read_blocking)
+      IO::FileDescriptor.new(handle: w, blocking: !!write_blocking)
     }
   end
 

src/crystal/event_loop/libevent.cr

@@ -118,10 +118,14 @@ class Crystal::EventLoop::LibEvent < Crystal::EventLoop
 
   def pipe(read_blocking : Bool?, write_blocking : Bool?) : {IO::FileDescriptor, IO::FileDescriptor}
     r, w = System::FileDescriptor.system_pipe
-    {
-      IO::FileDescriptor.new(r, !!read_blocking),
-      IO::FileDescriptor.new(w, !!write_blocking),
-    }
+
+    reader = IO::FileDescriptor.new(handle: r)
+    reader.blocking = !!read_blocking
+
+    writer = IO::FileDescriptor.new(handle: w)
+    writer.blocking = !!write_blocking
+
+    {reader, writer}
   end
 
   def open(path : String, flags : Int32, permissions : File::Permissions, blocking : Bool?) : {System::FileDescriptor::Handle, Bool} | Errno

src/crystal/event_loop/polling.cr

@@ -164,10 +164,14 @@ abstract class Crystal::EventLoop::Polling < Crystal::EventLoop
 
   def pipe(read_blocking : Bool?, write_blocking : Bool?) : {IO::FileDescriptor, IO::FileDescriptor}
     r, w = System::FileDescriptor.system_pipe
-    {
-      IO::FileDescriptor.new(r, !!read_blocking),
-      IO::FileDescriptor.new(w, !!write_blocking),
-    }
+
+    reader = IO::FileDescriptor.new(handle: r)
+    reader.blocking = !!read_blocking
+
+    writer = IO::FileDescriptor.new(handle: w)
+    writer.blocking = !!write_blocking
+
+    {reader, writer}
   end
 
   def open(path : String, flags : Int32, permissions : File::Permissions, blocking : Bool?) : {System::FileDescriptor::Handle, Bool} | Errno

src/crystal/system/process.cr

@@ -84,9 +84,9 @@ struct Crystal::System::Process
 end
 
 module Crystal::System
-  ORIGINAL_STDIN  = IO::FileDescriptor.new(Crystal::System::FileDescriptor::STDIN_HANDLE, blocking: true)
-  ORIGINAL_STDOUT = IO::FileDescriptor.new(Crystal::System::FileDescriptor::STDOUT_HANDLE, blocking: true)
-  ORIGINAL_STDERR = IO::FileDescriptor.new(Crystal::System::FileDescriptor::STDERR_HANDLE, blocking: true)
+  ORIGINAL_STDIN  = IO::FileDescriptor.new(handle: Crystal::System::FileDescriptor::STDIN_HANDLE, blocking: true)
+  ORIGINAL_STDOUT = IO::FileDescriptor.new(handle: Crystal::System::FileDescriptor::STDOUT_HANDLE, blocking: true)
+  ORIGINAL_STDERR = IO::FileDescriptor.new(handle: Crystal::System::FileDescriptor::STDERR_HANDLE, blocking: true)
 end
 
 {% if flag?(:wasi) %}

src/io/file_descriptor.cr

@@ -52,19 +52,30 @@ class IO::FileDescriptor < IO
   # event loop runtime requirements.
   #
   # NOTE: On Windows the handle should have been created with `FILE_FLAG_OVERLAPPED`.
-  # NOTE: The *blocking* arg is deprecated since Crystal 1.17. Use `#blocking=`
-  # to change the blocking mode instead.
-  def self.new(fd : Handle, blocking = nil, *, close_on_finalize = true)
+  def self.new(fd : Handle, *, close_on_finalize = true)
+    file_descriptor = new(handle: fd, close_on_finalize: close_on_finalize)
+    file_descriptor.system_blocking_init(nil) unless file_descriptor.closed?
+    file_descriptor
+  end
+
+  @[Deprecated("The blocking argument is deprecated. Use #blocking= to change it after creating the file descriptor.")]
+  def self.new(fd : Handle, blocking, *, close_on_finalize = true)
     file_descriptor = new(handle: fd, close_on_finalize: close_on_finalize)
     file_descriptor.system_blocking_init(blocking) unless file_descriptor.closed?
     file_descriptor
   end
 
   # :nodoc:
-  def initialize(*, handle : Handle, @close_on_finalize = true)
+  #
+  # Internal constructor to wrap a system *handle*. The *blocking* arg is purely
+  # informational.
+  def initialize(*, handle : Handle, @close_on_finalize = true, blocking = nil)
     @volatile_fd = Atomic.new(handle)
     @closed = true # This is necessary so we can reference `self` in `system_closed?` (in case of an exception)
     @closed = system_closed?
+    {% if flag?(:win32) %}
+      @system_blocking = !!blocking
+    {% end %}
   end
 
   # :nodoc: