Skip to content

Commit d3139b4

Browse files
Fmt + fix tensor min (#92)
1 parent 750a6ee commit d3139b4

File tree

2 files changed

+41
-1
lines changed

2 files changed

+41
-1
lines changed

spec/tensor/reduction_spec.cr

+40
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
# Copyright (c) 2023 Crystal Data Contributors
2+
#
3+
# MIT License
4+
#
5+
# Permission is hereby granted, free of charge, to any person obtaining
6+
# a copy of this software and associated documentation files (the
7+
# "Software"), to deal in the Software without restriction, including
8+
# without limitation the rights to use, copy, modify, merge, publish,
9+
# distribute, sublicense, and/or sell copies of the Software, and to
10+
# permit persons to whom the Software is furnished to do so, subject to
11+
# the following conditions:
12+
#
13+
# The above copyright notice and this permission notice shall be
14+
# included in all copies or substantial portions of the Software.
15+
#
16+
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
17+
# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
18+
# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
19+
# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
20+
# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
21+
# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
22+
# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
23+
24+
require "../spec_helper"
25+
26+
describe Tensor do
27+
it "can reduce a tensor's min along an axis" do
28+
input = [[-1, 1], [-1, 1]].to_tensor
29+
expected = [-1, -1].to_tensor
30+
31+
Num::Testing.tensor_equal(input.min(1), expected).should be_true
32+
end
33+
34+
it "can reduce a tensor's min to a scalar" do
35+
input = [[-2, 1], [-1, 1]].to_tensor
36+
expected = -2
37+
38+
(input.min == expected).should be_true
39+
end
40+
end

src/tensor/reduction.cr

+1-1
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ class Tensor(T, S)
239239
# Num.min(a) # => 3
240240
# ```
241241
def min : T
242-
Num.min(self, axis, dims)
242+
Num.min(self)
243243
end
244244

245245
# Reduces a `Tensor` along an axis, finding the min of each

0 commit comments

Comments
 (0)