Skip to content

Commit ca28303

Browse files
committed
fix minor issues [ci skip]
1 parent a584b78 commit ca28303

File tree

3 files changed

+10
-14
lines changed

3 files changed

+10
-14
lines changed

.github/workflows/build-linux.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,14 @@ jobs:
7171
- name: Set version
7272
run: mvn versions:set -DnewVersion=${{ needs.prepare.outputs.semVerStr }}
7373
- name: Run maven
74-
run: mvn -B clean package -Pwin -DskipTests
74+
run: mvn -B clean package -DskipTests
7575
- name: Patch target dir
7676
run: |
7777
cp LICENSE.txt target
7878
cp target/cryptomator-*.jar target/mods
7979
- name: Run jlink
8080
run: >
81-
${JAVA_HOME}/bin/jlink
81+
"${JAVA_HOME}/bin/jlink"
8282
--verbose
8383
--output target/runtime
8484
--module-path "${JAVA_HOME}/jmods"
@@ -90,7 +90,7 @@ jobs:
9090
--compress zip-6
9191
- name: Run jpackage
9292
run: >
93-
${JAVA_HOME}/bin/jpackage
93+
"${JAVA_HOME}/bin/jpackage"
9494
--verbose
9595
--type app-image
9696
--runtime-image target/runtime
@@ -103,7 +103,6 @@ jobs:
103103
--copyright "(C) 2016 - 2024 Skymatic GmbH"
104104
--app-version "${{ needs.prepare.outputs.semVerNum }}"
105105
--java-options "-Dorg.cryptomator.cli.version=${{ needs.prepare.outputs.semVerStr }}"
106-
--java-options "--enable-preview"
107106
--java-options "--enable-native-access=${{ matrix.native-access-lib }}"
108107
--java-options "-Xss5m"
109108
--java-options "-Xmx256m"

.github/workflows/build-mac.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,14 +69,14 @@ jobs:
6969
- name: Set version
7070
run: mvn versions:set -DnewVersion=${{ needs.prepare.outputs.semVerStr }}
7171
- name: Run maven
72-
run: mvn -B clean package -Pwin -DskipTests
72+
run: mvn -B clean package -DskipTests
7373
- name: Patch target dir
7474
run: |
7575
cp LICENSE.txt target
7676
cp target/cryptomator-*.jar target/mods
7777
- name: Run jlink
7878
run: >
79-
${JAVA_HOME}/bin/jlink
79+
"${JAVA_HOME}/bin/jlink"
8080
--verbose
8181
--output target/runtime
8282
--module-path "${JAVA_HOME}/jmods"
@@ -88,7 +88,7 @@ jobs:
8888
--compress zip-6
8989
- name: Run jpackage
9090
run: >
91-
${JAVA_HOME}/bin/jpackage
91+
"${JAVA_HOME}/bin/jpackage"
9292
--verbose
9393
--type app-image
9494
--runtime-image target/runtime
@@ -101,7 +101,6 @@ jobs:
101101
--copyright "(C) 2016 - 2024 Skymatic GmbH"
102102
--app-version "${{ needs.prepare.outputs.semVerNum }}"
103103
--java-options "-Dorg.cryptomator.cli.version=${{ needs.prepare.outputs.semVerStr }}"
104-
--java-options "--enable-preview"
105104
--java-options "--enable-native-access=org.cryptomator.jfuse.mac"
106105
--java-options "-Xss5m"
107106
--java-options "-Xmx256m"

.github/workflows/build-win.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,14 @@ jobs:
6161
- name: Set version
6262
run: mvn versions:set -DnewVersion=${{ needs.prepare.outputs.semVerStr }}
6363
- name: Run maven
64-
run: mvn -B clean package -Pwin -DskipTests
64+
run: mvn -B clean package -DskipTests
6565
- name: Patch target dir
6666
run: |
6767
cp LICENSE.txt target
6868
cp target/cryptomator-*.jar target/mods
6969
- name: Run jlink
7070
run: >
71-
${JAVA_HOME}/bin/jlink
71+
"${JAVA_HOME}/bin/jlink"
7272
--verbose
7373
--output target/runtime
7474
--module-path "${JAVA_HOME}/jmods"
@@ -80,7 +80,7 @@ jobs:
8080
--compress zip-6
8181
- name: Run jpackage
8282
run: >
83-
${JAVA_HOME}/bin/jpackage
83+
"${JAVA_HOME}/bin/jpackage"
8484
--verbose
8585
--type app-image
8686
--runtime-image target/runtime
@@ -93,7 +93,6 @@ jobs:
9393
--copyright "(C) 2016 - 2024 Skymatic GmbH"
9494
--app-version "${{ needs.prepare.outputs.semVerNum }}"
9595
--java-options "-Dorg.cryptomator.cli.version=${{ needs.prepare.outputs.semVerStr }}"
96-
--java-options "--enable-preview"
9796
--java-options "--enable-native-access=org.cryptomator.jfuse.win"
9897
--java-options "-Xss5m"
9998
--java-options "-Xmx256m"
@@ -105,8 +104,7 @@ jobs:
105104
path: ./target/cryptomator-cli
106105
if-no-files-found: error
107106
- name: TODO Sign binaries
108-
run: echo TODO; exit 1;
109-
#TODO
107+
run: echo TODO
110108
- name: Zip binary for release
111109
shell: pwsh
112110
run: Compress-Archive -Path .\target\cryptomator-cli -DestinationPath .\${{ env.artifact-name}}

0 commit comments

Comments
 (0)