Remove Elm application Feeds

Replace last functionality that had not been ported to LiveView yet by
regular <form>.

Author: cruessler

.github/workflows/ci.yml

@@ -79,13 +79,17 @@ jobs:
 
       - name: Precompile Elm entry points
         run: |
-          # By compiling both `Feeds.elm` and `NewFeed.elm`, we make sure all
-          # intermediate files are present before `npm run deploy` runs.
+          # By compiling `NewFeed.elm`, we make sure all intermediate files are
+          # present before `npm run deploy` runs.
           #
           # Otherwise, webpack would compile files in parallel which can lead
           # to data races and let one of the compiler processes fail with an
           # error about corrupt files.
-          npx elm make app/App/Feeds.elm --output /dev/null
+          #
+          # 2024-12-18
+          # This is probably not necessary anymore, but since the Elm parts
+          # will soon be completely removed, this doesn’t really matter and we
+          # can leave this step in place, just in case it is still necessary.
           npx elm make app/App/NewFeed.elm --output /dev/null
         working-directory: assets/elm
 

assets/elm/app/App/Feeds.elm

@@ -1,18 +1,13 @@
 module Feeds.Options.Discovery exposing
     ( addableFeed
-    , discoverFeedFieldset
-    , discoverFeedsFieldset
     , requestFieldset
     )
 
-import Dict exposing (Dict)
 import Feeds.Discovery as Discovery exposing (Discovery)
-import Feeds.Model exposing (..)
-import Feeds.Msg exposing (..)
+import Feeds.Msg exposing (Msg)
 import Html as H exposing (Html)
 import Html.Attributes as A
 import Html.Events as E
-import Http
 import Json.Decode as Decode
 import Request exposing (..)
 import Types.Feed exposing (..)
@@ -41,68 +36,6 @@ onEnter msg =
     E.on "keydown" <| Decode.andThen isEnter E.keyCode
 
 
-discoverFeedsFieldset : String -> Html Msg
-discoverFeedsFieldset discoveryUrl =
-    H.fieldset [ A.class "border-2 p-2" ]
-        [ H.legend [] [ H.text "Discover feeds on a site" ]
-        , H.label
-            [ A.for "feed-url" ]
-            [ H.text "Address to discover feeds on" ]
-        , H.input
-            [ A.id "feed-url"
-            , A.type_ "url"
-            , A.value discoveryUrl
-            , E.onInput SetDiscoveryUrl
-            , onEnter <| DiscoverFeeds discoveryUrl
-            ]
-            []
-        , H.button
-            [ A.class "px-4 py-2 text-sm font-extrabold bg-blue-700 text-white"
-            , E.onClick <| DiscoverFeeds discoveryUrl
-            ]
-            [ H.text "Discover" ]
-        , H.p
-            []
-            [ H.text "Enter the address of a site that contains one or more feeds. "
-            , H.text "Make sure it starts with "
-            , H.code [] [ H.text "http://" ]
-            , H.text " or "
-            , H.code [] [ H.text "https://" ]
-            , H.text "."
-            ]
-        ]
-
-
-discoverFeedFieldset : Html Msg
-discoverFeedFieldset =
-    H.fieldset [ A.class "border-2 p-2" ]
-        [ H.legend [] [ H.text "Add feed by address" ]
-        , H.form [ A.method "GET", A.action "/feeds/new/" ]
-            [ H.label [ A.for "add-feed-url" ] [ H.text "Address of the feed" ]
-            , H.input
-                [ A.id "add-feed-url"
-                , A.type_ "url"
-                , A.name "url"
-                ]
-                []
-            , H.input
-                [ A.class "px-4 py-2 text-sm font-extrabold bg-blue-700 text-white"
-                , A.type_ "submit"
-                , A.value "Discover"
-                ]
-                []
-            ]
-        , H.p []
-            [ H.text "Enter the address of an RSS or Atom feed. "
-            , H.text "Make sure it starts with "
-            , H.code [] [ H.text "http://" ]
-            , H.text " or "
-            , H.code [] [ H.text "https://" ]
-            , H.text "."
-            ]
-        ]
-
-
 inProgressFieldset : String -> Html Msg
 inProgressFieldset url =
     H.fieldset [ A.class "border-2 p-2" ]

assets/elm/app/Feeds/Icons.elm

@@ -1,4 +1,3 @@
-import Feeds from '../elm/app/App/Feeds.elm';
 import NewFeed from '../elm/app/App/NewFeed.elm';
 
 import { Socket } from '../../deps/phoenix';
@@ -30,7 +29,7 @@ liveSocket.connect();
 window.liveSocket = liveSocket;
 
 const Elm = {
-  App: { Feeds: Feeds.Elm.App.Feeds, NewFeed: NewFeed.Elm.App.NewFeed },
+  App: { NewFeed: NewFeed.Elm.App.NewFeed },
 };
 
 const mountElmModules = () => {