Skip to content
This repository was archived by the owner on Apr 3, 2020. It is now read-only.

Commit cb62553

Browse files
lwchkgMrunal Kapade
authored and
Mrunal Kapade
committed
[Backport] Fix undefined GYP_MSVS_VERSION failure for non-googlers
Original commit message: ------------------------ This CL adds the missing GYP_MSVS_VERSION environment variable. Without the patch the following error happen when a non-googler runs gyp_chromium in Windows. File "E:\chromium\src\tools\gyp\pylib\gyp\MSVSVersion.py", line 430, in SelectVisualStudioVersion raise ValueError('GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be ' ValueError: GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be set to a particular version (e.g. 2010e). The discussion is found here: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/XWZ3hZW8Lco BUG=460462 Review URL: https://codereview.chromium.org/1593313002
1 parent 931feb4 commit cb62553

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

build/vs_toolchain.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ def SetEnvironmentAndGetRuntimeDllDirs():
7171
elif sys.platform == 'win32' and not depot_tools_win_toolchain:
7272
if not 'GYP_MSVS_OVERRIDE_PATH' in os.environ:
7373
os.environ['GYP_MSVS_OVERRIDE_PATH'] = DetectVisualStudioPath()
74+
if not 'GYP_MSVS_VERSION' in os.environ:
75+
os.environ['GYP_MSVS_VERSION'] = GetVisualStudioVersion()
7476

7577
return vs_runtime_dll_dirs
7678

0 commit comments

Comments
 (0)