Skip to content
This repository was archived by the owner on Apr 3, 2020. It is now read-only.

Commit 82aec9c

Browse files
ernstmCommit bot
ernstm
authored and
Commit bot
committed
telemetry: remove run_measurment script.
[email protected],[email protected],[email protected] BUG=423563 Review URL: https://codereview.chromium.org/655563007 Cr-Commit-Position: refs/heads/master@{#299968}
1 parent 477dffe commit 82aec9c

File tree

8 files changed

+16
-66
lines changed

8 files changed

+16
-66
lines changed

chrome/telemetry.isolate

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
'conditions': [
99
['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', {
1010
# This list comes from running:
11-
# tools/perf/run_measurement --print-bootstrap-deps
11+
# tools/perf/run_benchmark --print-bootstrap-deps
1212
# and filtering out obvious undesired dependencies:
1313
# 'src/tools/perf/page_sets/'
1414
# 'src/tools/perf/measurements/'

tools/auto_bisect/bisect.cfg

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,11 @@ For ChromeOS:
5050
- Example:
5151
5252
config = {
53-
'command': ('./tools/perf/run_measurement -v --browser=cros-chrome-guest '
54-
'dromaeo.jslibstylejquery')
53+
'command': ('./tools/perf/run_benchmark -v --browser=cros-chrome-guest '
54+
'smoothness.key_mobile_sites')
5555
'good_revision': '4086.0.0',
5656
'bad_revision': '4087.0.0',
57-
'metric': 'jslib/jslib',
57+
'metric': 'mean_frame_time/mean_frame_time',
5858
}
5959
"""
6060

tools/perf/run_measurement

Lines changed: 0 additions & 32 deletions
This file was deleted.

tools/perf/run_multipage_benchmarks

Lines changed: 0 additions & 16 deletions
This file was deleted.

tools/run-perf-test.cfg

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ Args:
2929
Sample config:
3030
3131
config = {
32-
'command': './tools/perf/run_measurement --browser=release blink_perf third_party/WebKit/PerformanceTests/Layout/floats_50_100.html',
33-
'metric': 'floats_50_100/floats_50_100',
32+
'command': './tools/perf/run_benchmark --browser=release smoothness.key_mobile_sites',
33+
'metric': 'mean_frame_time/mean_frame_time',
3434
'repeat_count': '20',
3535
'max_time_minutes': '20',
3636
'truncate_percent': '25',
@@ -41,8 +41,8 @@ On Windows:
4141
the command:
4242
4343
config = {
44-
'command': 'python tools/perf/run_measurement -v --browser=release kraken',
45-
'metric': 'Total/Total',
44+
'command': 'python tools/perf/run_benchmark -v --browser=release smoothness.key_mobile_sites',
45+
'metric': 'mean_frame_time/mean_frame_time',
4646
'repeat_count': '20',
4747
'max_time_minutes': '20',
4848
'truncate_percent': '25',
@@ -55,10 +55,10 @@ On ChromeOS:
5555
the command using the bot's BISECT_CROS_IP and BISECT_CROS_BOARD values.
5656
5757
config = {
58-
'command': './tools/perf/run_measurement -v '\
58+
'command': './tools/perf/run_benchmark -v '\
5959
'--browser=cros-chrome-guest '\
60-
'dromaeo tools/perf/page_sets/dromaeo/jslibstylejquery.json',
61-
'metric': 'jslib/jslib',
60+
'smoothness.key_mobile_sites',
61+
'metric': 'mean_frame_time/mean_frame_time',
6262
'repeat_count': '20',
6363
'max_time_minutes': '20',
6464
'truncate_percent': '25',

tools/telemetry/build/generate_telemetry_harness.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
src/tools/telemetry/find_dependencies \
1111
src/tools/perf/run_benchmark \
12-
src/tools/perf/run_measurement \
1312
src/tools/perf/record_wpr \
1413
src/content/test/gpu/run_gpu_test.py \
1514
--exclude=*/third_party/trace-viewer/test_data/* \

tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,9 @@ def _AttemptTryjob(self, cfg_file_path):
108108
# Generate the command line for the perf trybots
109109
arguments = sys.argv
110110
if self._target_os == 'win':
111-
arguments[0] = 'python tools\\perf\\run_measurement'
111+
arguments[0] = 'python tools\\perf\\run_benchmark'
112112
else:
113-
arguments[0] = './tools/perf/run_measurement'
113+
arguments[0] = './tools/perf/run_benchmark'
114114
for index, arg in enumerate(arguments):
115115
if arg.startswith('--browser='):
116116
if self._target_os == 'android':

tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ def test_config_android(self):
204204
'trybot-android-nexus4', 'somebranch', 'tools/run-perf-test.cfg')
205205
self.assertEquals(
206206
('config = {\n'
207-
' "command": "./tools/perf/run_measurement '
207+
' "command": "./tools/perf/run_benchmark '
208208
'--browser=android-chrome-shell sunspider",\n'
209209
' "max_time_minutes": "120",\n'
210210
' "repeat_count": "1",\n'
@@ -216,7 +216,7 @@ def test_config_mac(self):
216216
'trybot-mac-10-9', 'currentwork', 'tools/run-perf-test.cfg')
217217
self.assertEquals(
218218
('config = {\n'
219-
' "command": "./tools/perf/run_measurement '
219+
' "command": "./tools/perf/run_benchmark '
220220
'--browser=release sunspider",\n'
221221
' "max_time_minutes": "120",\n'
222222
' "repeat_count": "1",\n'
@@ -228,10 +228,9 @@ def test_config_blink(self):
228228
'trybot-mac-10-9', 'blinkbranch', 'Tools/run-perf-test.cfg', True)
229229
self.assertEquals(
230230
('config = {\n'
231-
' "command": "./tools/perf/run_measurement '
231+
' "command": "./tools/perf/run_benchmark '
232232
'--browser=release sunspider",\n'
233233
' "max_time_minutes": "120",\n'
234234
' "repeat_count": "1",\n'
235235
' "truncate_percent": "0"\n'
236236
'}'), config)
237-

0 commit comments

Comments
 (0)