Skip to content

Commit 6cfe9cc

Browse files
authored
fix: mypy "type: ignore" comment errors (gorakhargosh#1016)
Before: ------- ``` (.venv) abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/watchdog (master) $ python -m tox -e mypy .pkg: _optional_hooks> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ .pkg: get_requires_for_build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ .pkg: build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ mypy: install_package> python -I -m pip install --force-reinstall --no-deps /Users/abramowi/Code/OpenSource/watchdog/.tox/.tmp/package/27/watchdog-3.0.1-0.editable-cp310-cp310-macosx_12_0_arm64.whl mypy: commands[0]> mypy src/watchdog/observers/fsevents2.py:32: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code [unused-ignore] src/watchdog/observers/fsevents2.py:33: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code [unused-ignore] src/watchdog/observers/fsevents.py:32: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code [unused-ignore] tests/test_fsevents.py:19: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code [unused-ignore] tests/test_skip_repeats_queue.py:109: error: Unused "type: ignore" comment, use narrower [import-untyped] instead of [import] code [unused-ignore] Found 5 errors in 4 files (checked 48 source files) mypy: exit 1 (0.63 seconds) /Users/abramowi/Code/OpenSource/watchdog> mypy pid=24917 .pkg: _exit> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ mypy: FAIL code 1 (1.67=setup[1.04]+cmd[0.63] seconds) evaluation failed :( (2.49 seconds) ``` After: ------ ``` (.venv) abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/watchdog (fix-mypy-type-ignore-import-errors) $ python -m tox -e mypy .pkg: _optional_hooks> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ .pkg: get_requires_for_build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ .pkg: build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ mypy: install_package> python -I -m pip install --force-reinstall --no-deps /Users/abramowi/Code/OpenSource/watchdog/.tox/.tmp/package/28/watchdog-3.0.1-0.editable-cp310-cp310-macosx_12_0_arm64.whl mypy: commands[0]> mypy Success: no issues found in 48 source files .pkg: _exit> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ mypy: OK (1.67=setup[1.05]+cmd[0.62] seconds) congratulations :) (2.44 seconds) ```
1 parent e4e2f8e commit 6cfe9cc

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

src/watchdog/observers/fsevents.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import time
3030
import unicodedata
3131

32-
import _watchdog_fsevents as _fsevents # type: ignore[import]
32+
import _watchdog_fsevents as _fsevents # type: ignore[import-not-found]
3333

3434
from watchdog.events import (
3535
DirCreatedEvent,

src/watchdog/observers/fsevents2.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
from typing import List, Optional, Type
3030

3131
# pyobjc
32-
import AppKit # type: ignore[import]
33-
from FSEvents import ( # type: ignore[import]
32+
import AppKit # type: ignore[import-not-found]
33+
from FSEvents import ( # type: ignore[import-not-found]
3434
CFRunLoopGetCurrent,
3535
CFRunLoopRun,
3636
CFRunLoopStop,

tests/test_fsevents.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
from time import sleep
1717
from unittest.mock import patch
1818

19-
import _watchdog_fsevents as _fsevents # type: ignore[import]
19+
import _watchdog_fsevents as _fsevents # type: ignore[import-not-found]
2020

2121
from watchdog.events import FileSystemEventHandler
2222
from watchdog.observers import Observer

tests/test_skip_repeats_queue.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def test_consecutives_allowed_across_empties():
106106
@cpython_only
107107
def test_eventlet_monkey_patching():
108108
try:
109-
import eventlet # type: ignore[import]
109+
import eventlet # type: ignore[import-untyped]
110110
except Exception:
111111
pytest.skip("eventlet not installed")
112112

0 commit comments

Comments
 (0)