Skip to content

[5.x]: Status Tags don't display well for multiline #17078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
segidev opened this issue Apr 4, 2025 · 4 comments · Fixed by #17082
Closed

[5.x]: Status Tags don't display well for multiline #17078

segidev opened this issue Apr 4, 2025 · 4 comments · Fixed by #17082
Assignees
Labels
accessibility 👤 features related to accessibility bug severity:minor Cosmetic issues or bugs with simple workarounds 🖥 UI

Comments

@segidev
Copy link

segidev commented Apr 4, 2025

What happened?

Description

Using Order status and having them with longer names might wrap the text. If that happens the color tag doesn't fully cover the text (see screenshot)

Steps to reproduce

  1. Create a status with a long name
  2. Make an order
  3. See the status in the list or also inside the order

Expected behavior

The tag should fully enclose the text

Actual behavior

The text is not encloded

Image

Image

Craft CMS version

Craft Pro 5.6.14

Craft Commerce version

5.3.8

PHP version

8.2.27

Operating system and version

Linux

Database type and version

Postgres 13

Image driver and version

No response

Installed plugins and versions

@segidev segidev added the bug label Apr 4, 2025
Copy link

linear bot commented Apr 4, 2025

@lukeholder lukeholder added 🖥 UI severity:minor Cosmetic issues or bugs with simple workarounds labels Apr 7, 2025
@lukeholder lukeholder transferred this issue from craftcms/commerce Apr 14, 2025
@lukeholder lukeholder added accessibility 👤 features related to accessibility and removed bug severity:minor Cosmetic issues or bugs with simple workarounds labels Apr 14, 2025
@lukeholder
Copy link
Member

@segidev Thank you for reporting this! I’ve moved it to the craftcms/cms project since craftcms/commerce is simply using Craft’s Cp::statusLabelHtml(). I believe that using text-overflow: ellipsis; might be the best solution, but I’ll leave it to our accessibility and UI team to weigh in. Thanks again!

@lukeholder lukeholder added bug severity:minor Cosmetic issues or bugs with simple workarounds labels Apr 14, 2025
@brianjhanson brianjhanson self-assigned this Apr 14, 2025
@brandonkelly
Copy link
Member

Craft 5.7.0 is out with a fix for this. Thanks again!

@segidev
Copy link
Author

segidev commented Apr 15, 2025

Can confirm it looks good now 👍
Image

@lukeholder lukeholder assigned lukeholder and unassigned brianjhanson May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 👤 features related to accessibility bug severity:minor Cosmetic issues or bugs with simple workarounds 🖥 UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants