Merge pull request #17200 from craftcms/bugfix/17197-gc-batch-ids-when-deleting-by-them

when deleting by IDs, split the deletion to 1000 per batch

Author: brandonkelly

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 - Fixed a bug where admin tables’ pagination footers could be positioned incorrectly in slideouts. ([#17187](https://github.com/craftcms/cms/issues/17187))
+- Fixed a SQL error that could occur when running garbage collection. ([#17197](https://github.com/craftcms/cms/issues/17197))
 - Fixed a styling issue.
 
 ## 4.15.2 - 2025-04-23

src/services/Gc.php

@@ -53,6 +53,11 @@ class Gc extends Component
      */
     public const EVENT_RUN = 'run';
 
+    /**
+     * @var int The number of items that should be deleted in a single batch.
+     */
+    private const CHUNK_SIZE = 10000;
+
     /**
      * @var int the probability (parts per million) that garbage collection (GC) should be performed
      * on a request. Defaults to 10, meaning 0.001% chance.
@@ -254,7 +259,9 @@ public function hardDeleteElements(): void
                 ->column();
 
             if (!empty($ids)) {
-                Db::delete(Table::ELEMENTS, ['id' => $ids]);
+                foreach (array_chunk($ids, self::CHUNK_SIZE) as $idsChunk) {
+                    Db::delete(Table::ELEMENTS, ['id' => $idsChunk]);
+                }
             }
         }
 
@@ -308,7 +315,9 @@ public function deletePartialElements(string $elementType, string $table, string
             ->column();
 
         if (!empty($ids)) {
-            Db::delete(Table::ELEMENTS, ['id' => $ids]);
+            foreach (array_chunk($ids, self::CHUNK_SIZE) as $idsChunk) {
+                Db::delete(Table::ELEMENTS, ['id' => $idsChunk]);
+            }
         }
 
         $this->_stdout("done\n", Console::FG_GREEN);
@@ -448,7 +457,9 @@ private function _deleteUnsupportedSiteEntries(): void
         }
 
         if (!empty($deleteIds)) {
-            Db::delete(Table::ELEMENTS_SITES, ['id' => $deleteIds]);
+            foreach (array_chunk($deleteIds, self::CHUNK_SIZE) as $deleteIdsChunk) {
+                Db::delete(Table::ELEMENTS_SITES, ['id' => $deleteIdsChunk]);
+            }
         }
 
         $this->_stdout("done\n", Console::FG_GREEN);
@@ -470,7 +481,9 @@ private function _deleteOrphanedDraftsAndRevisions(): void
                 ->column();
 
             if (!empty($ids)) {
-                Db::delete($table, ['id' => $ids]);
+                foreach (array_chunk($ids, self::CHUNK_SIZE) as $idsChunk) {
+                    Db::delete($table, ['id' => $idsChunk]);
+                }
             }
         }
 
@@ -496,7 +509,9 @@ private function _deleteOrphanedRelations(): void
             ->column();
 
         if (!empty($ids)) {
-            Db::delete(Table::RELATIONS, ['id' => $ids]);
+            foreach (array_chunk($ids, self::CHUNK_SIZE) as $idsChunk) {
+                Db::delete(Table::RELATIONS, ['id' => $idsChunk]);
+            }
         }
 
         $this->_stdout("done\n", Console::FG_GREEN);
@@ -518,7 +533,9 @@ private function _deleteOrphanedStructureElements(): void
             ->column();
 
         if (!empty($ids)) {
-            Db::delete(Table::STRUCTUREELEMENTS, ['id' => $ids]);
+            foreach (array_chunk($ids, self::CHUNK_SIZE) as $idsChunk) {
+                Db::delete(Table::STRUCTUREELEMENTS, ['id' => $idsChunk]);
+            }
         }
 
         $this->_stdout("done\n", Console::FG_GREEN);
@@ -636,7 +653,9 @@ public function deleteOrphanedFieldLayouts(string $elementType, string $table, s
             ->column();
 
         if (!empty($ids)) {
-            Db::delete(Table::FIELDLAYOUTS, ['id' => $ids]);
+            foreach (array_chunk($ids, self::CHUNK_SIZE) as $idsChunk) {
+                Db::delete(Table::FIELDLAYOUTS, ['id' => $idsChunk]);
+            }
         }
 
         $this->_stdout("done\n", Console::FG_GREEN);