Skip to content

Documentation error in nn.aggregation #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkterry1 opened this issue Jan 26, 2021 · 0 comments · Fixed by #301
Closed

Documentation error in nn.aggregation #222

jkterry1 opened this issue Jan 26, 2021 · 0 comments · Fixed by #301
Labels
documentation needed There is something missing from the documentation
Milestone

Comments

@jkterry1
Copy link
Collaborator

The documentation just kind of cuts off mid sentence?

class Aggregation(nn.Module):
    """
    Aggregation layer for the Dueling architecture.

    https://arxiv.org/abs/1511.06581
    This layer computes a Q function by combining
    an estimate of V with an estimate of the advantage.
    The advantage is normalized by subtracting the average
    advantage so that we can properly
    """

    def forward(self, value, advantages):
        return value + advantages - torch.mean(advantages, dim=1, keepdim=True)
@jkterry1 jkterry1 added the documentation needed There is something missing from the documentation label Jan 26, 2021
@cpnota cpnota added this to the Release 0.9.1 milestone Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation needed There is something missing from the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants