Skip to content

Should env.step() return done and info? #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mctigger opened this issue Jun 5, 2020 · 1 comment
Closed

Should env.step() return done and info? #149

mctigger opened this issue Jun 5, 2020 · 1 comment
Labels
documentation needed There is something missing from the documentation

Comments

@mctigger
Copy link
Contributor

mctigger commented Jun 5, 2020

Returns
-------
State
The state of the environment after the action is applied
float
The reward achieved by the previous action
done
True if the environment has entered a terminal state and should be reset
info
Diagnostic information useful for debugging

In the abstract Environment class it says that the step() methods should return the state, the reward, an indicator whether the episode ends and some information.

However, in the GymEnvironment only the reward and the state are returned:

return self._state, self._reward

Which usage should be the correct one?

@cpnota
Copy link
Owner

cpnota commented Jun 7, 2020

Ah, looks like the documentation is out of date. The State objective includes done and info now.

@cpnota cpnota added the documentation needed There is something missing from the documentation label Jun 7, 2020
@cpnota cpnota closed this as completed Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation needed There is something missing from the documentation
Projects
None yet
Development

No branches or pull requests

2 participants