Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting the ruler's rule query offset param #6055

Closed
klingerf opened this issue Jul 2, 2024 · 0 comments · Fixed by #6085
Closed

Add support for setting the ruler's rule query offset param #6055

klingerf opened this issue Jul 2, 2024 · 0 comments · Fixed by #6085
Labels
component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc.

Comments

@klingerf
Copy link
Contributor

klingerf commented Jul 2, 2024

Is your feature request related to a problem? Please describe.

We use Cortex as a remote_write backend. Newer versions of our remote_write client have introduced a delay in sending data to Cortex, such that recording rules that rely on this data are undercounting. It turns out Prometheus has a configuration for exactly this scenario, documented here, but it's not yet supported by Cortex.

Describe the solution you'd like

Ideally Cortex would support both the global rule_query_offset ruler configuration option, as well as the per-rulegroup override. The global configuration option could work similarly to the existing evaluation_interval option, which can also be overridden on individual rule groups.

Describe alternatives you've considered

None

Additional context

The new rule query offset configuration was added in prometheus/prometheus#14061, whch is scheduled for the upcoming prometheus 2.53.0 release. The prometheus dependency on master in this repo has already been bumped to a sha that includes that change.

@friedrichg friedrichg added the component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants