Skip to content

QueryFrontend sets incorrect status code on HTTP timeout #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmitsh opened this issue Apr 17, 2020 · 0 comments · Fixed by #2483
Closed

QueryFrontend sets incorrect status code on HTTP timeout #2482

dmitsh opened this issue Apr 17, 2020 · 0 comments · Fixed by #2483

Comments

@dmitsh
Copy link
Contributor

dmitsh commented Apr 17, 2020 •
edited
Loading

QueryFrontend does not check for the error from io.Copy, and sets incorrect status code if the error occurred.
@dmitsh dmitsh changed the title QueryFrontend logs incorrect status code on HTTP timeout QueryFrontend sets incorrect status code on HTTP timeout Apr 17, 2020
@dmitsh dmitsh mentioned this issue Apr 17, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

QueryFrontend sets incorrect status code on HTTP timeout dmitsh/cortex
1 participant
@dmitsh