Add comment on use of copiedLabels

bboreham · bboreham · commit bc9e4faab4bd · 2021-03-26T11:08:39.000Z
Signed-off-by: Bryan Boreham &lt;bjboreham@gmail.com&gt;
diff --git a/pkg/ingester/ingester_v2.go b/pkg/ingester/ingester_v2.go
@@ -799,6 +799,7 @@ func (i *Ingester) v2Push(ctx context.Context, req *cortexpb.WriteRequest) (*cor
 
 		if i.cfg.ActiveSeriesMetricsEnabled && succeededSamplesCount > oldSucceededSamplesCount {
 			db.activeSeries.UpdateSeries(cortexpb.FromLabelAdaptersToLabels(ts.Labels), startAppend, func(l labels.Labels) labels.Labels {
+				// we must already have copied the labels if succeededSamplesCount has been incremented.
 				return copiedLabels
 			})
 		}

Original file line number	Diff line number	Diff line change
`@@ -799,6 +799,7 @@ func (i Ingester) v2Push(ctx context.Context, req cortexpb.WriteRequest) (*cor`
`799`	`799`
`800`	`800`	`if i.cfg.ActiveSeriesMetricsEnabled && succeededSamplesCount > oldSucceededSamplesCount {`
`801`	`801`	`db.activeSeries.UpdateSeries(cortexpb.FromLabelAdaptersToLabels(ts.Labels), startAppend, func(l labels.Labels) labels.Labels {`
	`802`	`+ // we must already have copied the labels if succeededSamplesCount has been incremented.`
`802`	`803`	`return copiedLabels`
`803`	`804`	`})`
`804`	`805`	`}`