Skip to content

Commit 7dccf7f

Browse files
committed
Fix the Pull Request number in CHANGELOG.md
Signed-off-by: ChinYing-Li <[email protected]>
1 parent 0c4912a commit 7dccf7f

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
* [ENHANCEMENT] Querier / ruler: some optimizations to PromQL query engine. #3934 #3989
2222
* [ENHANCEMENT] Ingester: reduce CPU and memory when an high number of errors are returned by the ingester on the write path with the blocks storage. #3969 #3971 #3973
2323
* [ENHANCEMENT] Distributor: reduce CPU and memory when an high number of errors are returned by the distributor on the write path. #3990
24-
* [ENHANCEMENT] Put metric before label value in the "label value too long" error message. #3982
24+
* [ENHANCEMENT] Put metric before label value in the "label value too long" error message. #4018
2525
* [BUGFIX] Ruler-API: fix bug where `/api/v1/rules/<namespace>/<group_name>` endpoint return `400` instead of `404`. #4013
2626
* [BUGFIX] Distributor: reverted changes done to rate limiting in #3825. #3948
2727
* [BUGFIX] Ingester: Fix race condition when opening and closing tsdb concurrently. #3959

pkg/util/validation/errors.go

+8-8
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,14 @@ func (e *genericValidationError) Error() string {
2626
return fmt.Sprintf(e.message, e.cause, formatLabelSet(e.series))
2727
}
2828

29+
func newLabelNameTooLongError(series []cortexpb.LabelAdapter, labelName string) ValidationError {
30+
return &genericValidationError{
31+
message: "label name too long: %.200q metric %.200q",
32+
cause: labelName,
33+
series: series,
34+
}
35+
}
36+
2937
// labelValueTooLongError is a customized ValidationError, in that the cause and the series are
3038
// are formatted in different order in Error.
3139
type labelValueTooLongError struct {
@@ -37,14 +45,6 @@ func (e *labelValueTooLongError) Error() string {
3745
return fmt.Sprintf("label value too long for metric: %.200q label value: %.200q", formatLabelSet(e.series), e.labelValue)
3846
}
3947

40-
func newLabelNameTooLongError(series []cortexpb.LabelAdapter, labelName string) ValidationError {
41-
return &genericValidationError{
42-
message: "label name too long: %.200q metric %.200q",
43-
cause: labelName,
44-
series: series,
45-
}
46-
}
47-
4848
func newLabelValueTooLongError(series []cortexpb.LabelAdapter, labelValue string) ValidationError {
4949
return &labelValueTooLongError{
5050
labelValue: labelValue,

0 commit comments

Comments
 (0)