Skip to content

Commit 78a8848

Browse files
committed
add context cancellation checks on GetSeries
Signed-off-by: Erlan Zholdubai uulu <[email protected]>
1 parent 0cbc21f commit 78a8848

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

pkg/querier/distributor_queryable.go

+1-6
Original file line numberDiff line numberDiff line change
@@ -136,12 +136,7 @@ func (q *distributorQuerier) Select(ctx context.Context, sortSeries bool, sp *st
136136
if err != nil {
137137
return storage.ErrSeriesSet(err)
138138
}
139-
seriesSet, err := series.MetricsToSeriesSet(ctx, sortSeries, ms)
140-
if err != nil {
141-
return storage.ErrSeriesSet(err)
142-
}
143-
144-
return seriesSet
139+
return series.MetricsToSeriesSet(ctx, sortSeries, ms)
145140
}
146141

147142
return q.streamingSelect(ctx, sortSeries, minT, maxT, matchers)

pkg/querier/series/series_set.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -168,18 +168,18 @@ func MatrixToSeriesSet(sortSeries bool, m model.Matrix) storage.SeriesSet {
168168
}
169169

170170
// MetricsToSeriesSet creates a storage.SeriesSet from a []metric.Metric
171-
func MetricsToSeriesSet(ctx context.Context, sortSeries bool, ms []metric.Metric) (storage.SeriesSet, error) {
171+
func MetricsToSeriesSet(ctx context.Context, sortSeries bool, ms []metric.Metric) storage.SeriesSet {
172172
series := make([]storage.Series, 0, len(ms))
173173
for _, m := range ms {
174174
if ctx.Err() != nil {
175-
return nil, ctx.Err()
175+
return storage.ErrSeriesSet(ctx.Err())
176176
}
177177
series = append(series, &ConcreteSeries{
178178
labels: metricToLabels(m.Metric),
179179
samples: nil,
180180
})
181181
}
182-
return NewConcreteSeriesSet(sortSeries, series), nil
182+
return NewConcreteSeriesSet(sortSeries, series)
183183
}
184184

185185
func metricToLabels(m model.Metric) labels.Labels {

0 commit comments

Comments
 (0)