Skip to content

Commit 3cd209b

Browse files
committed
fixed rebase issues
Signed-off-by: Roy Chiang <[email protected]>
1 parent 1a7f65a commit 3cd209b

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

CHANGELOG.md

+1-7
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* [CHANGE] Distributor: Apply `max_fetched_series_per_query` limit for `/series` API. #4683
88
* [FEATURE] Ruler: Add `external_labels` option to tag all alerts with a given set of labels.
99
* [FEATURE] Compactor: Add `-compactor.skip-blocks-with-out-of-order-chunks-enabled` configuration to mark blocks containing index with out-of-order chunks for no compact instead of halting the compaction
10-
* [FEATURE] Add shuffle sharding grouper and planner within compactor to allow further work towards parallelizing compaction #4621
10+
* [FEATURE] Add shuffle sharding for the compactor #4433
1111

1212
## 1.12.0 in progress
1313

@@ -18,12 +18,6 @@
1818
* [CHANGE] Memberlist: changed probe interval from `1s` to `5s` and probe timeout from `500ms` to `2s`. #4601
1919
* [ENHANCEMENT] Update Go version to 1.17.8. #4602 #4604 #4658
2020
* [ENHANCEMENT] Keep track of discarded samples due to bad relabel configuration in `cortex_discarded_samples_total`. #4503
21-
* [FEATURE] Add shuffle sharding grouper and planner within compactor to allow further work towards parallelizing compaction #4624
22-
>>>>>>> bf3d29f2b (Fix up change log)
23-
* [FEATURE] Add shuffle sharding for the compactor #4433
24-
* [ENHANCEMENT] Update Go version to 1.17.5. #4602 #4604
25-
* [ENHANCEMENT] Keep track of discarded samples due to relabel configuration in `cortex_discarded_samples_total`. #4503
26-
>>>>>>> c2b1835ac (update changelog)
2721
* [ENHANCEMENT] Ruler: Add `-ruler.disable-rule-group-label` to disable the `rule_group` label on exported metrics. #4571
2822
* [ENHANCEMENT] Query federation: improve performance in MergeQueryable by memoizing labels. #4502
2923
* [ENHANCEMENT] Added new ring related config `-ingester.readiness-check-ring-health` when enabled the readiness probe will succeed only after all instances are ACTIVE and healthy in the ring, this is enabled by default. #4539

pkg/compactor/compactor.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ var (
5353
errInvalidShardingStrategy = errors.New("invalid sharding strategy")
5454
errInvalidTenantShardSize = errors.New("invalid tenant shard size, the value must be greater than 0")
5555

56-
DefaultBlocksGrouperFactory = func(ctx context.Context, cfg Config, bkt objstore.Bucket, logger log.Logger, reg prometheus.Registerer, blocksMarkedForDeletion , blocksMarkedForNoCompaction, garbageCollectedBlocks prometheus.Counter, _ prometheus.Gauge, _ *ring.Ring, _ *ring.Lifecycler, _ Limits, _ string) compact.Grouper {
56+
DefaultBlocksGrouperFactory = func(ctx context.Context, cfg Config, bkt objstore.Bucket, logger log.Logger, reg prometheus.Registerer, blocksMarkedForDeletion, blocksMarkedForNoCompaction, garbageCollectedBlocks prometheus.Counter, _ prometheus.Gauge, _ *ring.Ring, _ *ring.Lifecycler, _ Limits, _ string) compact.Grouper {
5757
return compact.NewDefaultGrouper(
5858
logger,
5959
bkt,
@@ -66,7 +66,7 @@ var (
6666
metadata.NoneFunc)
6767
}
6868

69-
ShuffleShardingGrouperFactory = func(ctx context.Context, cfg Config, bkt objstore.Bucket, logger log.Logger, reg prometheus.Registerer, blocksMarkedForDeletion prometheus.Counter, blocksMarkedForNoCompaction, garbageCollectedBlocks prometheus.Counter, remainingPlannedCompactions prometheus.Gauge, ring *ring.Ring, ringLifecycle *ring.Lifecycler, limits Limits, userID string) compact.Grouper {
69+
ShuffleShardingGrouperFactory = func(ctx context.Context, cfg Config, bkt objstore.Bucket, logger log.Logger, reg prometheus.Registerer, blocksMarkedForDeletion, blocksMarkedForNoCompaction, garbageCollectedBlocks prometheus.Counter, remainingPlannedCompactions prometheus.Gauge, ring *ring.Ring, ringLifecycle *ring.Lifecycler, limits Limits, userID string) compact.Grouper {
7070
return NewShuffleShardingGrouper(
7171
logger,
7272
bkt,

pkg/compactor/shuffle_sharding_grouper.go

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import (
77
"strings"
88
"time"
99

10-
"github.com/cortexproject/cortex/pkg/ring"
1110
"github.com/go-kit/log"
1211
"github.com/go-kit/log/level"
1312
"github.com/oklog/ulid"

0 commit comments

Comments
 (0)