Address PR comments

Signed-off-by: Alvin Lin <[email protected]>

Author: alvinlin123

CHANGELOG.md

@@ -41,7 +41,7 @@
 * [BUGFIX] Ruler: fixed counting of PromQL evaluation errors as user-errors when updating `cortex_ruler_queries_failed_total`. #4335
 * [BUGFIX] Ingester: When using block storage, prevent any reads or writes while the ingester is stopping. This will prevent accessing TSDB blocks once they have been already closed. #4304
 * [BUGFIX] Ingester: fixed ingester stuck on start up (LEAVING ring state) when `-ingester.heartbeat-period=0` and `-ingester.unregister-on-shutdown=false`. #4366
-* [BUGFIX] Querier can have lower concurrency after query-frontend restart. #4417
+* [BUGFIX] Querier: After query-frontend restart, querier may have lower than configured concurrency. #4417
 
 ## 1.10.0 / 2021-08-03
 

pkg/querier/worker/worker_test.go

@@ -31,39 +31,39 @@ func TestResetConcurrency(t *testing.T) {
 			maxConcurrent:                         0,
 			numTargets:                            2,
 			expectedConcurrency:                   2,
-			exepctedConcurrencyAfterTargetRemoval: 1,
+			expectedConcurrencyAfterTargetRemoval: 1,
 		},
 		{
 			name:                                  "Test parallelism per target",
 			parallelism:                           4,
 			maxConcurrent:                         0,
 			numTargets:                            2,
 			expectedConcurrency:                   8,
-			exepctedConcurrencyAfterTargetRemoval: 4,
+			expectedConcurrencyAfterTargetRemoval: 4,
 		},
 		{
 			name:                                  "Test Total Parallelism with a remainder",
 			parallelism:                           1,
 			maxConcurrent:                         7,
 			numTargets:                            4,
 			expectedConcurrency:                   7,
-			exepctedConcurrencyAfterTargetRemoval: 7,
+			expectedConcurrencyAfterTargetRemoval: 7,
 		},
 		{
 			name:                                  "Test Total Parallelism dividing evenly",
 			parallelism:                           1,
 			maxConcurrent:                         6,
 			numTargets:                            2,
 			expectedConcurrency:                   6,
-			exepctedConcurrencyAfterTargetRemoval: 6,
+			expectedConcurrencyAfterTargetRemoval: 6,
 		},
 		{
 			name:                                  "Test Total Parallelism at least one worker per target",
 			parallelism:                           1,
 			maxConcurrent:                         3,
 			numTargets:                            6,
 			expectedConcurrency:                   6,
-			exepctedConcurrencyAfterTargetRemoval: 5,
+			expectedConcurrencyAfterTargetRemoval: 5,
 		},
 	}
 
@@ -91,7 +91,7 @@ func TestResetConcurrency(t *testing.T) {
 
 			// now we remove an address and ensure we still have the expected concurrency
 			w.AddressRemoved(fmt.Sprintf("127.0.0.1:%d", rand.Intn(tt.numTargets)))
-			test.Poll(t, 250*time.Millisecond, tt.exepctedConcurrencyAfterTargetRemoval, func() interface{} {
+			test.Poll(t, 250*time.Millisecond, tt.expectedConcurrencyAfterTargetRemoval, func() interface{} {
 				return getConcurrentProcessors(w)
 			})