Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Rapid Test Profile shows mixed languages after change in locale #3972

Closed
3 tasks done
MikeMcC399 opened this issue Aug 24, 2021 · 20 comments · Fixed by #5668
Closed
3 tasks done

Rapid Test Profile shows mixed languages after change in locale #3972

MikeMcC399 opened this issue Aug 24, 2021 · 20 comments · Fixed by #5668
Assignees
Labels
bug Something isn't working Fix 3.0 Fix is planned for 3.0 mirrored-to-jira This item is also tracked internally in JIRA

Comments

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Aug 24, 2021

Avoid duplicates

  • Bug is not mentioned in the FAQ
  • Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
  • Bug is not already reported in another issue

Technical details

  • Device name: Google Pixel 3a emulator
  • Android version: 11
  • First reported on App version: 2.7.1
  • Confirmed still present on App version: 2.29.x

Describe the bug

If the device language is changed, the Rapid Test Profile input view does not refresh the field prompts.

Steps to reproduce the issue

(Updated for 2.29.x on Pixel 3a API 33 (Android 13))

  1. Settings > System > Languages and input > Languages, set English (United Kingdom)
  2. In CWA Status screen, tap "Manage Your Tests"
  3. Tap "Rapid Test Profile" (tap Continue if necessary), tap "+ Rapid Test Profiles"
  4. Note that all text is in English
  5. Without closing CWA, repeat step 1 and change preferred language to Deutsch (Deutschland)
  6. View CWA again and note the mixture of languages
  7. Tap back arrow
  8. Tap "+ Schnelltest-Profil"
  9. Now all text, including the field prompts are in German

App at step 6:

Rapid test profile mixed languages

Expected behavior

Android apps are expected to immediately respond to language changes. At step 6 in the steps to reproduce, the app should show only German text as in the following screen shot.

Rapid Test Profile all German

Additional information

Thanks to feedback from @PhilippNowak96 who identified that this is an issue of TextInputLayout in the Material Components, see: issue material-components/material-components-android#2075.

The Material Components issue is now closed through material-components/material-components-android@051410b. Material Components for Android 1.7.0 is supposed to fix this issue.


Internal Tracking ID: EXPOSUREAPP-9151

@MikeMcC399 MikeMcC399 added the bug Something isn't working label Aug 24, 2021
@dsarkar dsarkar added the mirrored-to-jira This item is also tracked internally in JIRA label Aug 24, 2021
@dsarkar
Copy link
Member

dsarkar commented Aug 24, 2021

@MikeMcC399 Thanks. Internal Tracking ID: EXPOSUREAPP-9151

@Ein-Tim Actually I can observe something similar on iOS. The country list when checking a DCC is in English, although the phone locale is set to DE. No way to get it to German back. iPhone 6s.

@MikeMcC399
Copy link
Contributor Author

@dsarkar

Actually I can observe something similar on iOS. The country list when checking a DCC is in English, although the phone locale is set to DE. No way to get it to German back. iPhone 6s.

That is an entirely different problem. Perhaps you should submit an issue in the iOS repository? It doesn't belong here at all. I checked by the way on Android, and Android correctly provides the list of countries in German, but this is not related to the Rapid Test Profile in any way.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Aug 24, 2021

@dsarkar

I will open an issue regarding this!

@PhilippNowak96
Copy link
Contributor

This seems to be an issue of TextInputLayout in the Material Components, see: material-components/material-components-android#2075

@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Aug 24, 2021

@PhilippNowak96

Thanks for uncovering that issue (material-components/material-components-android#2075)!

The standard Android elements TextView and Button refresh correctly. Everything else (which doesn't refresh correctly) is from com.google.android.material.textfield 😞.

Edit: Android issue material-components/material-components-android#2075 is open with label "Needs investigation".
It says there that the issue was introduced with 1.3.0-alpha03.

CWA is using com.google.android.material:material:1.3.0 so that fits.

implementation 'com.google.android.material:material:1.3.0'

@MikeMcC399
Copy link
Contributor Author

Closing as low impact and unsolved, due to the external component Material Components for Android (MDC-Android).

@dsarkar
Copy link
Member

dsarkar commented Apr 20, 2022

@MikeMcC399 thanks for your comment, forwarded to internal ticket.

@MikeMcC399
Copy link
Contributor Author

material-components/material-components-android#2075 is now closed with a fix, however there is not yet a new release of Material Components for Android (MDC-Android) containing this fix.

The upcoming CWA release 2.24.x is configured with
implementation 'com.google.android.material:material:1.6.0'

Judging by the progress in the https://github.com/material-components/material-components-android/ repository, the fix looks like it might be released with a material 1.7.x version.

@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Jul 15, 2022

Material Components for Android 1.7.0-alpha03 addresses this issue.

1.7.0-alpha03 requires a minimum compileSdkVersion and targetSdkVersion version 32 which makes it currently incompatible with release/2.25.x. The CWA Android 2.25.x branch is currently on version 31 of compileSdkVersion and targetSdkVersion. The app builds successfully after updating to version 32.

Updating
implementation 'com.google.android.material:material:1.6.0' to
implementation 'com.google.android.material:material:1.7.0-alpha03'
however produces fatal build errors, which would need investigation.

Edit: Superseded by 1.7.0-rc01

@dsarkar
Copy link
Member

dsarkar commented Jul 15, 2022

@MikeMcC399 Thanks, forwarded to internal ticket.

@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Oct 20, 2022

Re-opening this issue, since it still occurs and an official fix is now available.

Material Components for Android (MDC-Android) has now made Release 1.7.0 available which enables this CWA issue to be resolved without using an alpha or rc release. Fixed through commit material-components/material-components-android@051410b.

Perhaps there is scope in a future CWA version to incorporate this fix?

The official prerequisites however still include:
compileSdkVersion and targetSdkVersion minimum 32

This is not currently met by the 2.29 branch:

compileSdkVersion 31
buildToolsVersion "32.0.0"
defaultConfig {
applicationId 'de.rki.coronawarnapp'
minSdkVersion 23
targetSdkVersion 31

@MikeMcC399 MikeMcC399 reopened this Oct 20, 2022
@dsarkar
Copy link
Member

dsarkar commented Oct 20, 2022

Good morning @MikeMcC399! I will re-open the internal ticket and forward your findings! Thanks!

@dsarkar
Copy link
Member

dsarkar commented Oct 31, 2022

@MikeMcC399 FYI PR #5668

@dsarkar dsarkar added the Fix 3.0 Fix is planned for 3.0 label Oct 31, 2022
@MikeMcC399
Copy link
Contributor Author

@MikeMcC399
Copy link
Contributor Author

Fix is included in pre-release version v2.29.0-rc.0.

@MikeMcC399

This comment was marked as resolved.

@MikeMcC399

This comment was marked as resolved.

@MikeMcC399
Copy link
Contributor Author

The label Fix 3.0 Fix is planned for 3.0 has been edited, however the text hasn't been changed, so it is out of sync.

image

Please check and correct in the https://github.com/corona-warn-app/cwa-app-android/labels list.

@larswmh
Copy link
Member

larswmh commented Dec 12, 2022

@MikeMcC399

The label Fix 3.0 Fix is planned for 3.0 has been edited, however the text hasn't been changed, so it is out of sync.

image

Please check and correct in the https://github.com/corona-warn-app/cwa-app-android/labels list.

The label description has been changed now, thanks for the hint

@MikeMcC399
Copy link
Contributor Author

The issue has been fixed and is awaiting release.

According to BMG on Twitter CWA 3.0 has a planned release date of Wednesday, Jan 18, 2023. Since this is an edge case it won't be noticed by most users, so I am closing it in advance of the release.

@larswmh Thanks for fixing the label text.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Fix 3.0 Fix is planned for 3.0 mirrored-to-jira This item is also tracked internally in JIRA
Projects
None yet
7 participants