Update since onboarding error code (Dev) (#5712)

Author: mtwalli

Corona-Warn-App/src/main/java/de/rki/coronawarnapp/srs/core/SrsLocalChecker.kt

@@ -60,7 +60,7 @@ class SrsLocalChecker @Inject constructor(
                 onboardingInHours
             )
             throw SrsSubmissionException(
-                errorCode = ErrorCode.TIME_SINCE_ONBOARDING_UNVERIFIED,
+                errorCode = ErrorCode.MIN_TIME_SINCE_ONBOARDING,
                 errorArgs = arrayOf(onboardingInHours.toHours(), onboardingInHours.toHours())
             )
         }

Corona-Warn-App/src/main/java/de/rki/coronawarnapp/srs/core/error/SrsSubmissionException.kt

@@ -22,6 +22,8 @@ class SrsSubmissionException(
             TextKey.TIME_SINCE_ONBOARDING_UNVERIFIED
         ),
 
+        MIN_TIME_SINCE_ONBOARDING("MIN_TIME_SINCE_ONBOARDING", TextKey.TIME_SINCE_ONBOARDING_UNVERIFIED),
+
         SRS_OTP_CLIENT_ERROR("SRS_OTP_CLIENT_ERROR", TextKey.CALL_HOTLINE),
         SRS_OTP_NO_NETWORK("SRS_OTP_NO_NETWORK", TextKey.NO_NETWORK),
         SRS_OTP_SERVER_ERROR("SRS_OTP_SERVER_ERROR", TextKey.TRY_AGAIN_LATER),

Corona-Warn-App/src/main/java/de/rki/coronawarnapp/srs/core/server/SrsAuthorizationServer.kt

@@ -85,6 +85,7 @@ class SrsAuthorizationServer @Inject constructor(
                     errorArgs = errorArgs(errorCode)
                 )
             }
+
             response?.expirationDate != null -> OffsetDateTime.parse(response.expirationDate).toInstant()
             else -> throw when (bodyResponse.code()) {
                 400 -> SrsSubmissionException(ErrorCode.SRS_OTP_400)
@@ -107,7 +108,9 @@ class SrsAuthorizationServer @Inject constructor(
                 .timeBetweenSubmissionsInDays
                 .toDays()
         )
-        ErrorCode.TIME_SINCE_ONBOARDING_UNVERIFIED -> {
+
+        ErrorCode.TIME_SINCE_ONBOARDING_UNVERIFIED,
+        ErrorCode.MIN_TIME_SINCE_ONBOARDING -> {
             val hours = appConfigProvider
                 .currentConfig
                 .first()
@@ -117,6 +120,7 @@ class SrsAuthorizationServer @Inject constructor(
                 .toHours()
             arrayOf(hours, hours)
         }
+
         else -> emptyArray()
     }
 

Corona-Warn-App/src/test/java/de/rki/coronawarnapp/srs/core/SrsLocalCheckerTest.kt

@@ -71,7 +71,7 @@ internal class SrsLocalCheckerTest : BaseTest() {
         every { cwaSettings.firstReliableDeviceTime } returns flowOf(Instant.parse("2022-11-02T10:01:22Z"))
         shouldThrow<SrsSubmissionException> {
             instance().check()
-        }.errorCode shouldBe SrsSubmissionException.ErrorCode.TIME_SINCE_ONBOARDING_UNVERIFIED
+        }.errorCode shouldBe SrsSubmissionException.ErrorCode.MIN_TIME_SINCE_ONBOARDING
     }
 
     @Test

Corona-Warn-App/src/test/java/de/rki/coronawarnapp/srs/core/server/SrsAuthorizationServerTest.kt

@@ -131,6 +131,12 @@ internal class SrsAuthorizationServerTest : BaseTest() {
             "JWS_SIGNATURE_VERIFICATION_FAILED" to ErrorCode.JWS_SIGNATURE_VERIFICATION_FAILED,
             "NONCE_MISMATCH" to ErrorCode.NONCE_MISMATCH,
             "SALT_REDEEMED" to ErrorCode.SALT_REDEEMED,
+
+            // Should not be thrown by server ,but just in case it is also covered
+            "TIME_SINCE_ONBOARDING_UNVERIFIED" to ErrorCode.TIME_SINCE_ONBOARDING_UNVERIFIED,
+            "MIN_TIME_SINCE_ONBOARDING" to ErrorCode.MIN_TIME_SINCE_ONBOARDING,
+            "SUBMISSION_TOO_EARLY" to ErrorCode.SUBMISSION_TOO_EARLY,
+
             // iOS error that does not map to Android Error :D
             "API_TOKEN_ALREADY_ISSUED" to ErrorCode.SRS_OTP_SERVER_ERROR,
         ).forEach { (serverErrorCode, errorCode) ->