Skip to content

Possible typo in IndexKernel documentation #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
parrangoiz opened this issue Jan 15, 2025 · 2 comments · Fixed by #2625
Closed

Possible typo in IndexKernel documentation #2620

parrangoiz opened this issue Jan 15, 2025 · 2 comments · Fixed by #2625

Comments

@parrangoiz
Copy link
Contributor

The IndexKernel documentation says that raw_var is the element-wise log of the $\mathbf{v}$ vector. If I'm not mistaken it is actually the softplus of $\mathbf{v}$ instead, assuming the default constraint (Positive). Maybe a bit fastidious but this threw me for a spin when I was trying to manually reconstruct the task covariance matrix by hand from the factors and the diagonal.

@gpleiss
Copy link
Member

gpleiss commented Jan 16, 2025

Good catch. Mind submitting a PR with the fix?

@parrangoiz
Copy link
Contributor Author

Sure no problem! First wanted to double check I was right since I'm new to the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants