-
Notifications
You must be signed in to change notification settings - Fork 684
Towards a more uniform API for declare.ml (part declaring mutual statements) #18795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
coqbot-app
merged 12 commits into
rocq-prover:master
from
herbelin:master+uniform-API-declare.ml
May 28, 2024
Merged
Towards a more uniform API for declare.ml (part declaring mutual statements) #18795
coqbot-app
merged 12 commits into
rocq-prover:master
from
herbelin:master+uniform-API-declare.ml
May 28, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23ea0f6
to
aa23b15
Compare
aa23b15
to
036a797
Compare
036a797
to
510069e
Compare
510069e
to
658fb69
Compare
658fb69
to
5c8cd90
Compare
67d436e
to
317a52e
Compare
Sounds good @herbelin , I have no strong opinion, if we find a better name we can change it later of course. |
Adopting the plural form then. |
317a52e
to
3c84501
Compare
This was referenced May 26, 2024
ppedrot
approved these changes
May 28, 2024
@coqbot merge now |
@ppedrot: Please take care of the following overlays:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind: cleanup
Code removal, deprecation, refactorings, etc.
part: vernac
High level command interpretation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to present some uniformity in the API of
declare.ml
so that it is clearer to compare the different functions. It should not change the semantics.Depends on
#18742 and#18743 (merged).It has an impact on the exact API though with the following API changes:
function renamings
declare_mutually_recursive
->declare_mutual_definition
(+ labelrec_declaration
->bodies
), consistently withdeclare_definition
start_with_initialization
->start_definition
start_mutual_with_initialization
->start_mutual_definition
(+ labelinit_term
->bodies
)other labels renaming
add_definition
:term
->body
, andopaque
made mandatoryadd_mutual_definitions
: argument (cinfo,bodies,obls) -> labelscinfo
andbodies
+ obls kept as unnamed argumentTODO, pending question: mutual_definition or mutual_definitions?
Overlays (due to opaque made mandatory)