Skip to content

Commit c1d4197

Browse files
author
shaleman
committed
fix ovs delete unittest
1 parent abbb840 commit c1d4197

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

drivers/ovsdbDriver.go

+11-2
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import (
1919
"errors"
2020
"fmt"
2121
"reflect"
22+
"time"
2223

2324
"github.com/contiv/libovsdb"
2425
"github.com/contiv/netplugin/core"
@@ -82,8 +83,16 @@ func NewOvsdbDriver(bridgeName string, failMode string) (*OvsdbDriver, error) {
8283
// Delete : Cleanup the ovsdb driver. delete the bridge we created.
8384
func (d *OvsdbDriver) Delete() error {
8485
if d.ovs != nil {
85-
d.createDeleteBridge(d.bridgeName, "", operDeleteBridge)
8686
log.Infof("Deleting OVS bridge: %s", d.bridgeName)
87+
for i := 0; i < 3; i++ {
88+
err := d.createDeleteBridge(d.bridgeName, "", operDeleteBridge)
89+
if err != nil {
90+
log.Errorf("Error deleting the bridge %s. Err: %v", d.bridgeName, err)
91+
time.Sleep(300 * time.Millisecond)
92+
} else {
93+
break
94+
}
95+
}
8796
(*d.ovs).Disconnect()
8897
}
8998

@@ -153,7 +162,7 @@ func (d *OvsdbDriver) performOvsdbOps(ops []libovsdb.Operation) error {
153162
return nil
154163
}
155164

156-
log.Errorf("OVS operation failed for op: %+v", ops)
165+
log.Errorf("OVS operation failed for op: %+v: Errors: %v", ops, errors)
157166

158167
return core.Errorf("ovs operation failed. Error(s): %v", errors)
159168
}

0 commit comments

Comments
 (0)