Skip to content

Commit c0a7667

Browse files
committed
review feedback
1 parent d934060 commit c0a7667

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

Makefile

+3-2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
.PHONY: all all-CI build clean default unit-test release tar checks go-version gofmt-src \
66
golint-src govet-src run-build compile-with-docker
77

8+
DEFAULT_DOCKER_VERSION := 1.12.6
89
SHELL := /bin/bash
910
EXCLUDE_DIRS := bin docs Godeps scripts vagrant vendor install
1011
PKG_DIRS := $(filter-out $(EXCLUDE_DIRS),$(subst /,,$(sort $(dir $(wildcard */)))))
@@ -126,7 +127,7 @@ update:
126127
# setting CONTIV_NODES=<number> while calling 'make demo' can be used to bring
127128
# up a cluster of <number> nodes. By default <number> = 1
128129
start:
129-
CONTIV_NODE_OS=${CONTIV_NODE_OS} vagrant up
130+
CONTIV_DOCKER_VERSION="$${CONTIV_DOCKER_VERSION:-$(DEFAULT_DOCKER_VERSION)}" CONTIV_NODE_OS=${CONTIV_NODE_OS} vagrant up
130131

131132
# ===================================================================
132133
#kubernetes demo targets
@@ -210,7 +211,7 @@ ssh:
210211
@vagrant ssh netplugin-node1 -c 'bash -lc "cd /opt/gopath/src/github.com/contiv/netplugin/ && bash"' || echo 'Please run "make demo"'
211212

212213
ssh-build: start
213-
$(call make-on-node1, run-build install-shell-completion)
214+
vagrant ssh netplugin-node1 -c 'bash -lc "source /etc/profile.d/envvar.sh && cd /opt/gopath/src/github.com/contiv/netplugin && make run-build install-shell-completion"'
214215

215216
unit-test: stop clean
216217
./scripts/unittests -vagrant

scripts/jenkins_cleanup.sh

100644100755
File mode changed.

0 commit comments

Comments
 (0)