Skip to content

Commit 86d8913

Browse files
author
Vipin Jain
committed
Merge branch 'add_systests'
2 parents 2380280 + 1aa75c2 commit 86d8913

File tree

9 files changed

+711
-133
lines changed

9 files changed

+711
-133
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,4 @@ unit-test: build
2525

2626
system-test: build
2727
go test -v github.com/contiv/netplugin/systemtests/singlehost
28-
go test -v github.com/contiv/netplugin/systemtests/twohosts
28+
go test --timeout 20m -v github.com/contiv/netplugin/systemtests/twohosts

netd.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,7 @@ func main() {
511511
defHostLabel,
512512
"label used to identify endpoints homed for this host, default is host name")
513513
flagSet.BoolVar(&opts.publishVtep,
514-
"do-not-publish-vtep",
514+
"publish-vtep",
515515
true,
516516
"publish the vtep when allowed by global policy")
517517

netdcli/cfg.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,9 @@ func processAdditions(stateDriver core.StateDriver, allCfg *netmaster.Config) (e
152152

153153
func processDeletions(stateDriver core.StateDriver, allCfg *netmaster.Config) (err error) {
154154
for _, tenant := range allCfg.Tenants {
155-
err = netmaster.DeleteTenant(stateDriver, &tenant)
155+
err = netmaster.DeleteEndpoints(stateDriver, &tenant)
156156
if err != nil {
157-
log.Printf("error deleting tenant '%s' \n", err)
157+
log.Printf("error deleting endpoints '%s' \n", err)
158158
continue
159159
}
160160

@@ -164,9 +164,9 @@ func processDeletions(stateDriver core.StateDriver, allCfg *netmaster.Config) (e
164164
continue
165165
}
166166

167-
err = netmaster.DeleteEndpoints(stateDriver, &tenant)
167+
err = netmaster.DeleteTenant(stateDriver, &tenant)
168168
if err != nil {
169-
log.Printf("error deleting endpoints '%s' \n", err)
169+
log.Printf("error deleting tenant '%s' \n", err)
170170
continue
171171
}
172172
}

netmaster/netmaster.go

+8-1
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,11 @@ func DeleteTenant(stateDriver core.StateDriver, tenant *ConfigTenant) error {
205205
return err
206206
}
207207

208-
return DeleteTenantId(stateDriver, tenant.Name)
208+
if len(tenant.Networks) == 0 {
209+
return DeleteTenantId(stateDriver, tenant.Name)
210+
}
211+
212+
return nil
209213
}
210214

211215
func validateNetworkConfig(tenant *ConfigTenant) error {
@@ -455,6 +459,9 @@ func DeleteNetworks(stateDriver core.StateDriver, tenant *ConfigTenant) error {
455459
}
456460

457461
for _, network := range tenant.Networks {
462+
if len(network.Endpoints) > 0 {
463+
continue
464+
}
458465
nwMasterCfg := &MasterNwConfig{StateDriver: stateDriver}
459466
err = nwMasterCfg.Read(network.Name)
460467
if err != nil {

netutils/netutils.go

+8-2
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@ func ParseTagRanges(ranges string, tagType string) ([]TagRange, error) {
213213

214214
func GetLocalIp() (string, error) {
215215
var addrs []netlink.Addr
216+
localIpAddr := ""
216217

217218
for idx := 0; idx < 3; idx++ {
218219
linkName := "eth" + strconv.Itoa(idx)
@@ -228,11 +229,16 @@ func GetLocalIp() (string, error) {
228229
return "", err
229230
}
230231
if len(addrs) > 0 {
231-
return addrs[0].IP.String(), nil
232+
localIpAddr = addrs[0].IP.String()
232233
}
233234
}
234235

235-
return "", errors.New("local ip not found")
236+
err := errors.New("local ip not found")
237+
if localIpAddr != "" {
238+
err = nil
239+
}
240+
241+
return localIpAddr, err
236242
}
237243

238244
func ParseCIDR(cidrStr string) (string, uint, error) {

0 commit comments

Comments
 (0)