Skip to content

Commit 66fcd2b

Browse files
shalemanshaleman
committed
Merge pull request #5 from contiv/vxlan
move vlan/vxlan range to global object
2 parents 3b56d98 + 7380f46 commit 66fcd2b

12 files changed

+108
-156
lines changed

‎app.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
"properties": {
99
"appName": {
1010
"type": "string",
11-
"description": "Application Name"
11+
"title": "Application Name"
1212
},
1313
"tenantName": {
1414
"type": "string",
15-
"description": "Tenant Name"
15+
"title": "Tenant Name"
1616
}
1717
},
1818
"link-sets": {

‎client/contivModel.js

+21-29
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ var AppModalView = React.createClass({
4444
<div className='modal-body' style={ {margin: '5%',} }>
4545

4646

47-
<Input type='text' label='' ref='appName' defaultValue={obj.appName} placeholder='' />
47+
<Input type='text' label='Application Name' ref='appName' defaultValue={obj.appName} placeholder='Application Name' />
4848

49-
<Input type='text' label='' ref='tenantName' defaultValue={obj.tenantName} placeholder='' />
49+
<Input type='text' label='Tenant Name' ref='tenantName' defaultValue={obj.tenantName} placeholder='Tenant Name' />
5050

5151
</div>
5252
<div className='modal-footer'>
@@ -145,7 +145,7 @@ var GlobalSummaryView = React.createClass({
145145
<td>{ global.name }</td>
146146

147147
<td>{ global.network-infra-type }</td>
148-
148+
149149
</tr>
150150
</ModalTrigger>
151151
);
@@ -159,7 +159,7 @@ var GlobalSummaryView = React.createClass({
159159

160160

161161
<th> name of this block </th>
162-
<th> Network infrastructure type </th>
162+
<th> Network infrastructure type </th>
163163
</tr>
164164
</thead>
165165
<tbody>
@@ -183,6 +183,10 @@ var GlobalModalView = React.createClass({
183183

184184
<Input type='text' label='Network infrastructure type' ref='network-infra-type' defaultValue={obj.network-infra-type} placeholder='Network infrastructure type' />
185185

186+
<Input type='text' label='Allowed vlan range' ref='vlans' defaultValue={obj.vlans} placeholder='Allowed vlan range' />
187+
188+
<Input type='text' label='Allwed vxlan range' ref='vxlans' defaultValue={obj.vxlans} placeholder='Allwed vxlan range' />
189+
186190
</div>
187191
<div className='modal-footer'>
188192
<Button onClick={this.props.onRequestHide}>Close</Button>
@@ -208,7 +212,7 @@ var NetworkSummaryView = React.createClass({
208212
<td>{ network.encap }</td>
209213

210214
<td>{ network.gateway }</td>
211-
215+
212216
<td>{ network.networkName }</td>
213217

214218
<td>{ network.pktTag }</td>
@@ -228,7 +232,7 @@ var NetworkSummaryView = React.createClass({
228232

229233

230234
<th> Encapsulation </th>
231-
<th> Gateway </th>
235+
<th> Gateway </th>
232236
<th> Network name </th>
233237
<th> Vlan/Vxlan Tag </th>
234238
<th> Subnet </th>
@@ -255,10 +259,6 @@ var NetworkModalView = React.createClass({
255259

256260
<Input type='text' label='Gateway' ref='gateway' defaultValue={obj.gateway} placeholder='Gateway' />
257261

258-
<Input type='text' label='Private network' ref='isPrivate' defaultValue={obj.isPrivate} placeholder='Private network' />
259-
260-
<Input type='text' label='Public network' ref='isPublic' defaultValue={obj.isPublic} placeholder='Public network' />
261-
262262
<Input type='text' label='Network name' ref='networkName' defaultValue={obj.networkName} placeholder='Network name' />
263263

264264
<Input type='text' label='Vlan/Vxlan Tag' ref='pktTag' defaultValue={obj.pktTag} placeholder='Vlan/Vxlan Tag' />
@@ -488,7 +488,7 @@ var ServiceModalView = React.createClass({
488488
<div className='modal-body' style={ {margin: '5%',} }>
489489

490490

491-
<Input type='text' label='' ref='appName' defaultValue={obj.appName} placeholder='' />
491+
<Input type='text' label='Application Name' ref='appName' defaultValue={obj.appName} placeholder='Application Name' />
492492

493493
<Input type='text' label='' ref='command' defaultValue={obj.command} placeholder='' />
494494

@@ -506,9 +506,9 @@ var ServiceModalView = React.createClass({
506506

507507
<Input type='text' label='' ref='scale' defaultValue={obj.scale} placeholder='' />
508508

509-
<Input type='text' label='' ref='serviceName' defaultValue={obj.serviceName} placeholder='' />
509+
<Input type='text' label='Service Name' ref='serviceName' defaultValue={obj.serviceName} placeholder='Service Name' />
510510

511-
<Input type='text' label='' ref='tenantName' defaultValue={obj.tenantName} placeholder='' />
511+
<Input type='text' label='Tenant Name' ref='tenantName' defaultValue={obj.tenantName} placeholder='Tenant Name' />
512512

513513
<Input type='text' label='' ref='volumeProfile' defaultValue={obj.volumeProfile} placeholder='' />
514514

@@ -567,11 +567,11 @@ var ServiceInstanceModalView = React.createClass({
567567

568568
<Input type='text' label='' ref='appName' defaultValue={obj.appName} placeholder='' />
569569

570-
<Input type='text' label='' ref='instanceId' defaultValue={obj.instanceId} placeholder='' />
570+
<Input type='text' label='Service instance id' ref='instanceId' defaultValue={obj.instanceId} placeholder='Service instance id' />
571571

572572
<Input type='text' label='' ref='serviceName' defaultValue={obj.serviceName} placeholder='' />
573573

574-
<Input type='text' label='' ref='tenantName' defaultValue={obj.tenantName} placeholder='' />
574+
<Input type='text' label='Tenant Name' ref='tenantName' defaultValue={obj.tenantName} placeholder='Tenant Name' />
575575

576576
<Input type='text' label='' ref='volumes' defaultValue={obj.volumes} placeholder='' />
577577

@@ -596,7 +596,7 @@ var TenantSummaryView = React.createClass({
596596
<ModalTrigger modal={<TenantModalView tenant={ tenant }/>}>
597597
<tr key={ tenant.key } className="info">
598598

599-
599+
600600
</tr>
601601
</ModalTrigger>
602602
);
@@ -608,7 +608,7 @@ var TenantSummaryView = React.createClass({
608608
<thead>
609609
<tr>
610610

611-
611+
612612
</tr>
613613
</thead>
614614
<tbody>
@@ -630,16 +630,8 @@ var TenantModalView = React.createClass({
630630

631631
<Input type='text' label='Network name' ref='defaultNetwork' defaultValue={obj.defaultNetwork} placeholder='Network name' />
632632

633-
<Input type='text' label='' ref='subnetLen' defaultValue={obj.subnetLen} placeholder='' />
634-
635-
<Input type='text' label='' ref='subnetPool' defaultValue={obj.subnetPool} placeholder='' />
636-
637633
<Input type='text' label='Tenant Name' ref='tenantName' defaultValue={obj.tenantName} placeholder='Tenant Name' />
638634

639-
<Input type='text' label='' ref='vlans' defaultValue={obj.vlans} placeholder='' />
640-
641-
<Input type='text' label='' ref='vxlans' defaultValue={obj.vxlans} placeholder='' />
642-
643635
</div>
644636
<div className='modal-footer'>
645637
<Button onClick={this.props.onRequestHide}>Close</Button>
@@ -701,9 +693,9 @@ var VolumeModalView = React.createClass({
701693

702694
<Input type='text' label='' ref='size' defaultValue={obj.size} placeholder='' />
703695

704-
<Input type='text' label='' ref='tenantName' defaultValue={obj.tenantName} placeholder='' />
696+
<Input type='text' label='Tenant Name' ref='tenantName' defaultValue={obj.tenantName} placeholder='Tenant Name' />
705697

706-
<Input type='text' label='' ref='volumeName' defaultValue={obj.volumeName} placeholder='' />
698+
<Input type='text' label='Volume Name' ref='volumeName' defaultValue={obj.volumeName} placeholder='Volume Name' />
707699

708700
</div>
709701
<div className='modal-footer'>
@@ -766,9 +758,9 @@ var VolumeProfileModalView = React.createClass({
766758

767759
<Input type='text' label='' ref='size' defaultValue={obj.size} placeholder='' />
768760

769-
<Input type='text' label='' ref='tenantName' defaultValue={obj.tenantName} placeholder='' />
761+
<Input type='text' label='Tenant Name' ref='tenantName' defaultValue={obj.tenantName} placeholder='Tenant Name' />
770762

771-
<Input type='text' label='' ref='volumeProfileName' defaultValue={obj.volumeProfileName} placeholder='' />
763+
<Input type='text' label='Volume profile Name' ref='volumeProfileName' defaultValue={obj.volumeProfileName} placeholder='Volume profile Name' />
772764

773765
</div>
774766
<div className='modal-footer'>

‎client/contivModelClient.go

+27-31
Original file line numberDiff line numberDiff line change
@@ -142,11 +142,11 @@ type EndpointGroup struct {
142142
// every object has a key
143143
Key string `json:"key,omitempty"`
144144

145-
EndpointGroupID int `json:"endpointGroupId,omitempty"` //
146-
GroupName string `json:"groupName,omitempty"` // Endpoint group Name
147-
NetworkName string `json:"networkName,omitempty"` //
145+
EndpointGroupID int `json:"endpointGroupId,omitempty"` // Group Identifier
146+
GroupName string `json:"groupName,omitempty"` // Group name
147+
NetworkName string `json:"networkName,omitempty"` // Network
148148
Policies []string `json:"policies,omitempty"`
149-
TenantName string `json:"tenantName,omitempty"` // Tenant Name
149+
TenantName string `json:"tenantName,omitempty"` // Tenant
150150

151151
// add link-sets and links
152152
LinkSets EndpointGroupLinkSets `json:"link-sets,omitempty"`
@@ -167,23 +167,23 @@ type Global struct {
167167
// every object has a key
168168
Key string `json:"key,omitempty"`
169169

170-
Name string `json:"name,omitempty"` //
171-
NetworkInfraType string `json:"network-infra-type,omitempty"` //
170+
Name string `json:"name,omitempty"` // name of this block
171+
NetworkInfraType string `json:"network-infra-type,omitempty"` // Network infrastructure type
172+
Vlans string `json:"vlans,omitempty"` // Allowed vlan range
173+
Vxlans string `json:"vxlans,omitempty"` // Allwed vxlan range
172174

173175
}
174176

175177
type Network struct {
176178
// every object has a key
177179
Key string `json:"key,omitempty"`
178180

179-
Encap string `json:"encap,omitempty"` //
180-
Gateway string `json:"gateway,omitempty"` //
181-
IsPrivate bool `json:"isPrivate,omitempty"` //
182-
IsPublic bool `json:"isPublic,omitempty"` //
183-
NetworkName string `json:"networkName,omitempty"` //
184-
PktTag int `json:"pktTag,omitempty"` //
185-
Subnet string `json:"subnet,omitempty"` //
186-
TenantName string `json:"tenantName,omitempty"` //
181+
Encap string `json:"encap,omitempty"` // Encapsulation
182+
Gateway string `json:"gateway,omitempty"` // Gateway
183+
NetworkName string `json:"networkName,omitempty"` // Network name
184+
PktTag int `json:"pktTag,omitempty"` // Vlan/Vxlan Tag
185+
Subnet string `json:"subnet,omitempty"` // Subnet
186+
TenantName string `json:"tenantName,omitempty"` // Tenant Name
187187

188188
// add link-sets and links
189189
LinkSets NetworkLinkSets `json:"link-sets,omitempty"`
@@ -224,17 +224,17 @@ type Rule struct {
224224
// every object has a key
225225
Key string `json:"key,omitempty"`
226226

227-
Action string `json:"action,omitempty"` //
228-
Direction string `json:"direction,omitempty"` //
229-
EndpointGroup string `json:"endpointGroup,omitempty"` //
230-
IpAddress string `json:"ipAddress,omitempty"` //
231-
Network string `json:"network,omitempty"` //
232-
PolicyName string `json:"policyName,omitempty"` //
233-
Port int `json:"port,omitempty"` //
234-
Priority int `json:"priority,omitempty"` //
235-
Protocol string `json:"protocol,omitempty"` //
236-
RuleID string `json:"ruleId,omitempty"` //
237-
TenantName string `json:"tenantName,omitempty"` //
227+
Action string `json:"action,omitempty"` // Action
228+
Direction string `json:"direction,omitempty"` // Direction
229+
EndpointGroup string `json:"endpointGroup,omitempty"` // Group
230+
IpAddress string `json:"ipAddress,omitempty"` // IP Address
231+
Network string `json:"network,omitempty"` // Network Name
232+
PolicyName string `json:"policyName,omitempty"` // Policy Name
233+
Port int `json:"port,omitempty"` // Port No
234+
Priority int `json:"priority,omitempty"` // Priority
235+
Protocol string `json:"protocol,omitempty"` // Protocol
236+
RuleID string `json:"ruleId,omitempty"` // Rule Id
237+
TenantName string `json:"tenantName,omitempty"` // Tenant Name
238238

239239
// add link-sets and links
240240
LinkSets RuleLinkSets `json:"link-sets,omitempty"`
@@ -304,12 +304,8 @@ type Tenant struct {
304304
// every object has a key
305305
Key string `json:"key,omitempty"`
306306

307-
DefaultNetwork string `json:"defaultNetwork,omitempty"` //
308-
SubnetLen int `json:"subnetLen,omitempty"` //
309-
SubnetPool string `json:"subnetPool,omitempty"` //
310-
TenantName string `json:"tenantName,omitempty"` //
311-
Vlans string `json:"vlans,omitempty"` //
312-
Vxlans string `json:"vxlans,omitempty"` //
307+
DefaultNetwork string `json:"defaultNetwork,omitempty"` // Network name
308+
TenantName string `json:"tenantName,omitempty"` // Tenant Name
313309

314310
// add link-sets and links
315311
LinkSets TenantLinkSets `json:"link-sets,omitempty"`

‎client/contivModelClient.py

+2-6
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,8 @@ def createGlobal(self, obj):
146146
jdata = json.dumps({
147147
"name": obj.name,
148148
"network-infra-type": obj.network-infra-type,
149+
"vlans": obj.vlans,
150+
"vxlans": obj.vxlans,
149151
})
150152

151153
# Post the data
@@ -178,8 +180,6 @@ def createNetwork(self, obj):
178180
jdata = json.dumps({
179181
"encap": obj.encap,
180182
"gateway": obj.gateway,
181-
"isPrivate": obj.isPrivate,
182-
"isPublic": obj.isPublic,
183183
"networkName": obj.networkName,
184184
"pktTag": obj.pktTag,
185185
"subnet": obj.subnet,
@@ -365,11 +365,7 @@ def createTenant(self, obj):
365365

366366
jdata = json.dumps({
367367
"defaultNetwork": obj.defaultNetwork,
368-
"subnetLen": obj.subnetLen,
369-
"subnetPool": obj.subnetPool,
370368
"tenantName": obj.tenantName,
371-
"vlans": obj.vlans,
372-
"vxlans": obj.vxlans,
373369
})
374370

375371
# Post the data

0 commit comments

Comments
 (0)