Update prepackage.js

Author: Patrick-Erichsen

extensions/vscode/scripts/prepackage.js

@@ -77,7 +77,7 @@ const isWinTarget = target?.startsWith("win");
 
   process.chdir("../../gui");
 
-  execCmdSync("npm install");
+  execCmdSync("NODE_OPTIONS=--no-warnings npm install");
   console.log("[info] npm install in gui completed");
 
   if (isInGitHubAction) {
@@ -325,86 +325,59 @@ const isWinTarget = target?.startsWith("win");
     }
   }
 
-  // // GitHub Actions doesn't support ARM, so we need to download pre-saved binaries
-  // if (ghAction() && isArm()) {
-  //   // sqlite3
-  //   // Neither lancedb nor sqlite3 have pre-built windows arm64 binaries
-
-  //   // lancedb binary
-  //   const packageToInstall = {
-  //     "darwin-arm64": "@lancedb/vectordb-darwin-arm64",
-  //     "win32-arm64": "@lancedb/vectordb-win32-arm64-msvc",
-  //     "linux-arm64": "@lancedb/vectordb-linux-arm64-gnu",
-  //   }[target];
-  //   console.log(
-  //     "[info] Downloading pre-built lancedb binary: " + packageToInstall,
-  //   );
-
-  //   await installNodeModuleInTempDirAndCopyToCurrent(
-  //     packageToInstall,
-  //     "@lancedb",
-  //   );
-
-  //   if (isWin()) {
-  //     // Replace the installed with pre-built
-  //     console.log("[info] Downloading pre-built sqlite3 binary");
-  //     rimrafSync("../../core/node_modules/sqlite3/build");
-  //     const downloadUrl = {
-  //       "darwin-arm64":
-  //         "https://github.com/TryGhost/node-sqlite3/releases/download/v5.1.7/sqlite3-v5.1.7-napi-v6-darwin-arm64.tar.gz",
-  //       "linux-arm64":
-  //         "https://github.com/TryGhost/node-sqlite3/releases/download/v5.1.7/sqlite3-v5.1.7-napi-v3-linux-arm64.tar.gz",
-  //     }[target];
-  //     execCmdSync(
-  //       `curl -L -o ../../core/node_modules/sqlite3/build.tar.gz ${downloadUrl}`,
-  //     );
-  // execCmdSync(
-  //   "cd ../../core/node_modules/sqlite3 && tar -xvzf build.tar.gz",
-  // );
-  // fs.unlinkSync("../../core/node_modules/sqlite3/build.tar.gz");
-  //   } else {
-  //     console.log("[info] Building sqlite3 binary from source for ", target);
-  //     rimrafSync("../../core/node_modules/sqlite3/build");
-  //     execCmdSync(
-  //       `npm rebuild sqlite3 --build-from-source --target_arch=arm64 --fallback-to-build`,
-  //     );
-  //   }
-
-  //   // Download and unzip esbuild
-  //   console.log("[info] Downloading pre-built esbuild binary");
-  //   rimrafSync("node_modules/@esbuild");
-  //   fs.mkdirSync("node_modules/@esbuild", { recursive: true });
-  //   execCmdSync(
-  //     `curl -o node_modules/@esbuild/esbuild.zip https://continue-server-binaries.s3.us-west-1.amazonaws.com/${target}/esbuild.zip`,
-  //   );
-  //   execCmdSync(`cd node_modules/@esbuild && unzip esbuild.zip`);
-  //   fs.unlinkSync("node_modules/@esbuild/esbuild.zip");
-  // } else {
-  //   // Download esbuild from npm in tmp and copy over
-  //   console.log("npm installing esbuild binary");
-  //   await installNodeModuleInTempDirAndCopyToCurrent(
-  //     "[email protected]",
-  //     "@esbuild",
-  //   );
-  // }
-
-  if (isWinTarget && isArmTarget) {
-    const downloadUrl =
-      "https://continue-server-binaries.s3.us-west-1.amazonaws.com/win32-arm64/sqlite3.zip";
+  // GitHub Actions doesn't support ARM, so we need to download pre-saved binaries
+  // 02/07/25 - the above comment is out of date, there is now support for ARM runners on GitHub Actions
+  if (isInGitHubAction && isArmTarget) {
+    // lancedb binary
+    const packageToInstall = {
+      "darwin-arm64": "@lancedb/vectordb-darwin-arm64",
+      "win32-arm64": "@lancedb/vectordb-win32-arm64-msvc",
+      "linux-arm64": "@lancedb/vectordb-linux-arm64-gnu",
+    }[target];
+    console.log(
+      "[info] Downloading pre-built lancedb binary: " + packageToInstall,
+    );
+
+    await installNodeModuleInTempDirAndCopyToCurrent(
+      packageToInstall,
+      "@lancedb",
+    );
+
+    // Replace the installed sqlite3 with pre-built
+    console.log("[info] Downloading pre-built sqlite3 binary");
     rimrafSync("../../core/node_modules/sqlite3/build");
+    const downloadUrl = {
+      "darwin-arm64":
+        "https://github.com/TryGhost/node-sqlite3/releases/download/v5.1.7/sqlite3-v5.1.7-napi-v6-darwin-arm64.tar.gz",
+      "linux-arm64":
+        "https://github.com/TryGhost/node-sqlite3/releases/download/v5.1.7/sqlite3-v5.1.7-napi-v3-linux-arm64.tar.gz",
+      // node-sqlite3 doesn't have a pre-built binary for win32-arm64
+      "win32-arm64":
+        "https://continue-server-binaries.s3.us-west-1.amazonaws.com/win32-arm64/node_sqlite3.node",
+    }[target];
     execCmdSync(
       `curl -L -o ../../core/node_modules/sqlite3/build.tar.gz ${downloadUrl}`,
     );
     execCmdSync("cd ../../core/node_modules/sqlite3 && tar -xvzf build.tar.gz");
     fs.unlinkSync("../../core/node_modules/sqlite3/build.tar.gz");
-  }
 
-  // Download esbuild from npm in tmp and copy over
-  console.log("npm installing esbuild binary");
-  await installNodeModuleInTempDirAndCopyToCurrent(
-    "[email protected]",
-    "@esbuild",
-  );
+    // Download and unzip esbuild
+    console.log("[info] Downloading pre-built esbuild binary");
+    rimrafSync("node_modules/@esbuild");
+    fs.mkdirSync("node_modules/@esbuild", { recursive: true });
+    execCmdSync(
+      `curl -o node_modules/@esbuild/esbuild.zip https://continue-server-binaries.s3.us-west-1.amazonaws.com/${target}/esbuild.zip`,
+    );
+    execCmdSync(`cd node_modules/@esbuild && unzip esbuild.zip`);
+    fs.unlinkSync("node_modules/@esbuild/esbuild.zip");
+  } else {
+    // Download esbuild from npm in tmp and copy over
+    console.log("npm installing esbuild binary");
+    await installNodeModuleInTempDirAndCopyToCurrent(
+      "[email protected]",
+      "@esbuild",
+    );
+  }
 
   console.log("[info] Copying sqlite node binding from core");
   await new Promise((resolve, reject) => {
@@ -532,11 +505,7 @@ const isWinTarget = target?.startsWith("win");
     // out/node_modules (to be accessed by extension.js)
     `out/node_modules/@vscode/ripgrep/bin/rg${exe}`,
     `out/node_modules/@esbuild/${
-      target === "win32-arm64"
-        ? "esbuild.exe"
-        : target === "win32-x64"
-          ? "win32-x64/esbuild.exe"
-          : `${target}/bin/esbuild`
+      isWinTarget ? `${target}/esbuild.exe` : `${target}/bin/esbuild`
     }`,
     `out/node_modules/@lancedb/vectordb-${target}${os === "linux" ? "-gnu" : ""}/index.node`,
     `out/node_modules/esbuild/lib/main.js`,