Update pr_checks.yaml

Author: Patrick-Erichsen

.github/workflows/pr_checks.yaml

@@ -101,7 +101,7 @@ jobs:
           OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
 
   install-gui:
-    needs: [install-root, install-core]
+    needs: [ install-root, install-core ]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -164,7 +164,7 @@ jobs:
           npx tsc --noEmit
 
   binary-checks:
-    needs: [install-root, install-core]
+    needs: [ install-root, install-core ]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -201,7 +201,7 @@ jobs:
           npx tsc --noEmit
 
   install-vscode:
-    needs: [install-root, install-core]
+    needs: [ install-root, install-core ]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -294,7 +294,7 @@ jobs:
 
   vscode-get-test-file-matrix:
     runs-on: ubuntu-latest
-    needs: [install-root, install-vscode]
+    needs: [ install-root, install-vscode ]
     outputs:
       test_file_matrix: ${{ steps.vscode-get-test-file-matrix.outputs.test_file_matrix }}
     steps:
@@ -323,7 +323,7 @@ jobs:
 
   vscode-package-extension:
     runs-on: ubuntu-latest
-    needs: [install-vscode, install-core]
+    needs: [ install-vscode, install-core ]
     steps:
       - uses: actions/checkout@v4
 
@@ -356,7 +356,7 @@ jobs:
 
   vscode-download-e2e-dependencies:
     runs-on: ubuntu-latest
-    needs: [install-vscode, install-core]
+    needs: [ install-vscode, install-core ]
     steps:
       - uses: actions/checkout@v4
 
@@ -404,7 +404,7 @@ jobs:
       fail-fast: false
       matrix:
         test_file: ${{ fromJson(needs.vscode-get-test-file-matrix.outputs.test_file_matrix) }}
-        command: ["e2e:ci:run", "e2e:ci:run-yaml"]
+        command: [ "e2e:ci:run", "e2e:ci:run-yaml" ]
     steps:
       - uses: actions/checkout@v4
 
@@ -467,7 +467,7 @@ jobs:
           path: extensions/vscode/e2e/storage/screenshots
 
   gui-tests:
-    needs: [install-gui, install-core]
+    needs: [ install-gui, install-core ]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -498,11 +498,48 @@ jobs:
           cd gui
           npm test
 
+
   jetbrains-tests:
-    needs: [install-root, core-checks]
-    runs-on: ubuntu-latest
+    needs: [ install-root, core-checks ]
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ ubuntu-latest, windows-latest ]
+        include:
+          - os: ubuntu-latest
+            runIde: |
+              export DISPLAY=:99.0
+              Xvfb -ac :99 -screen 0 1920x1080x24 &
+              sleep 10
+              mkdir -p extensions/intellij/build/reports
+              ./gradlew runIdeForUiTests &
+            runTests: |
+              export DISPLAY=:99.0
+              ./gradlew test
+            url: http://127.0.0.1:8082
+            reportName: jb-failure-report-linux
+            shell: bash
+            moveVideo: mv extensions/intellij/video extensions/intellij/build/reports
+            copyLogs: mv extensions/intellij/build/idea-sandbox/system/log/ extensions/intellij/build/reports
+            reportsPath: extensions/intellij/build/reports
+
+          - os: windows-latest
+            runIde: |
+              set DISPLAY=:99.0
+              start /B gradlew.bat runIdeForUiTests
+              mkdir extensions\intellij\build\reports
+            runTests: |
+              ./gradlew test
+            url: http://localhost:8082
+            reportName: jb-failure-report-windows
+            shell: pwsh
+            moveVideo: Move-Item extensions\intellij\video extensions\intellij\build\reports
+            copyLogs: Move-Item extensions\intellij\build\idea-sandbox\system\log\ extensions\intellij\build\reports
+            reportsPath: extensions\intellij\build\reports
+    runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v4
+
       - uses: actions/cache@v4
         with:
           path: core/node_modules
@@ -533,7 +570,6 @@ jobs:
           path: gui/node_modules
           key: ${{ runner.os }}-gui-node-modules-${{ hashFiles('gui/package-lock.json') }}
 
-      # We can shave off another minute off our CI script by finding a way to share this with vscode-tests
       - name: Run prepackage script
         run: |
           cd extensions/vscode
@@ -554,48 +590,37 @@ jobs:
           cd binary
           npm run build
 
-      - name: Start test IDE
-        run: |
-          cd extensions/intellij
-          export DISPLAY=:99.0
-          Xvfb -ac :99 -screen 0 1920x1080x24 &
-          sleep 10
-          mkdir -p build/reports
-          ./gradlew runIdeForUiTests &
+      - name: Run IDE
+        shell: ${{ matrix.shell }}
+        run: ${{ matrix.runIde }}
 
       - name: Wait for JB connection
         uses: jtalk/url-health-check-action@v3
         with:
-          url: http://127.0.0.1:8082
+          url: ${{ matrix.url }}
           max-attempts: 15
           retry-delay: 30s
 
       - name: Run tests
-        run: |
-          cd extensions/intellij
-          export DISPLAY=:99.0
-          ./gradlew test
+        shell: ${{ matrix.shell }}
+        run: ${{ matrix.runTests }}
 
       - name: Move video
         if: ${{ failure() }}
-        run: |
-          cd extensions/intellij
-          mv video build/reports
+        shell: ${{ matrix.shell }}
+        run: ${{ matrix.moveVideo }}
 
       - name: Copy logs
         if: ${{ failure() }}
-        run: |
-          cd extensions/intellij
-          mv build/idea-sandbox/system/log/ build/reports
+        shell: ${{ matrix.shell }}
+        run: ${{ matrix.copyLogs }}
 
       - name: Save fails report
         if: ${{ failure() }}
         uses: actions/upload-artifact@v4
         with:
-          name: jb-failure-report
-          path: |
-            ${{ github.workspace }}/extensions/intellij/build/reports
-
+          name: ${{ matrix.reportName }}
+          path: ${{ matrix.reportsPath }}
   # GitHub does not have a way of requiring that all checks pass (you must manually select each job)
   # This action at least lets us manage the list of required tests via source control
   # so that creators of new jobs can add them to this list