Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a method is removed the deployed items are not cleaned up #252

Open
cooktheryan opened this issue Sep 12, 2022 · 1 comment
Open

If a method is removed the deployed items are not cleaned up #252

cooktheryan opened this issue Sep 12, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@cooktheryan
Copy link
Collaborator

Right now if you remove a method is removed from a configuration file the item just runs forever without ever getting cleaned up and is lost from FetchIt configuration. We can get around this by first removing the container definition from git and then removing the configuration value.

@cooktheryan cooktheryan added the bug Something isn't working label Sep 12, 2022
@guest20
Copy link

guest20 commented Jan 4, 2023

in puppet one would first release a change with ensure: "absent" on the resource before deleting it from the config file.

Another option is to have fetchit automatically stop any pods that it's not managing (which might be a valid design choice, but makes adopting fetchit troublesome, because it'll immediately stop everything you've already set up if you run it even once to try it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants