Skip to content

Commit 5f30187

Browse files
committed
Fix: allowListed first check as isGoogleURL & edit order & description of preferences
1 parent 24f88bc commit 5f30187

File tree

2 files changed

+9
-13
lines changed

2 files changed

+9
-13
lines changed

background.js

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,11 @@ function shouldContainInto (url, tab) {
343343
return false;
344344
}
345345

346-
let handleUrl = isGoogleURL(url);
346+
let handleUrl = isGoogleURL(url) || (extensionSettings.allowlist.length!=0 && isAllowlistedURL(url));
347+
348+
if (handleUrl && extensionSettings.whitelist.length!=0 && isWhitelistedURL(url)) {
349+
handleUrl = false;
350+
}
347351

348352
if (handleUrl && extensionSettings.ignore_youtube && isYouTubeURL(url)) {
349353
handleUrl = false;
@@ -369,14 +373,6 @@ function shouldContainInto (url, tab) {
369373
handleUrl = false;
370374
}
371375

372-
if (handleUrl && extensionSettings.whitelist.length!=0 && isWhitelistedURL(url)) {
373-
handleUrl = false;
374-
}
375-
376-
if (!handleUrl && extensionSettings.allowlist.length!=0 && isAllowlistedURL(url)) {
377-
handleUrl = true;
378-
}
379-
380376
if (handleUrl) {
381377
if (tab.cookieStoreId !== googleCookieStoreId) {
382378
if (tab.cookieStoreId !== "firefox-default" && extensionSettings.dont_override_containers) {

options.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,20 +64,20 @@ <h1>Settings</h1>
6464

6565
<p>
6666
<label>
67-
<textarea id="whitelist" value="" cols="80">
67+
<textarea id="allowlist" value="" cols="80">
6868
</textarea>
6969
<br>
70-
Whitelisted google urls<br>
70+
Allowlisted urls to use Google Container (for example third party SSO)<br>
7171
<em>(Use one url per line.)</em>
7272
</label>
7373
</p>
7474

7575
<p>
7676
<label>
77-
<textarea id="allowlist" value="" cols="80">
77+
<textarea id="whitelist" value="" cols="80">
7878
</textarea>
7979
<br>
80-
Allowlisted urls to use Google Container<br>
80+
Whitelisted urls (Google or allowlisted)<br>
8181
<em>(Use one url per line.)</em>
8282
</label>
8383
</p>

0 commit comments

Comments
 (0)