Skip to content

Python 3.13 migrator fails with KeyError: 'patch' in (recently added) ops code #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakirkham opened this issue Oct 24, 2024 · 7 comments

Comments

@jakirkham
Copy link
Member

Am seeing the following error with the polars migration in this bot job:

Traceback (most recent call last):
  File "/home/runner/work/cf-scripts/cf-scripts/cf-scripts/conda_forge_tick/auto_tick.py", line 721, in _run_migrator_on_feedstock_branch
    migrator_uid, pr_json = run_with_tmpdir(
                            ^^^^^^^^^^^^^^^^
  File "/home/runner/work/cf-scripts/cf-scripts/cf-scripts/conda_forge_tick/auto_tick.py", line 445, in run_with_tmpdir
    return run(
           ^^^^
  File "/home/runner/work/cf-scripts/cf-scripts/cf-scripts/conda_forge_tick/auto_tick.py", line 547, in run
    rerender_info = _run_rerender(
                    ^^^^^^^^^^^^^^
  File "/home/runner/work/cf-scripts/cf-scripts/cf-scripts/conda_forge_tick/auto_tick.py", line 252, in _run_rerender
    rerender_msg = rerender_feedstock(str(context.local_clone_dir), timeout=900)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/cf-scripts/cf-scripts/cf-scripts/conda_forge_tick/rerender_feedstock.py", line 24, in rerender_feedstock
    return _rerender(feedstock_dir, timeout=timeout, use_container=use_container)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/micromamba/envs/cf-scripts/lib/python3.11/site-packages/conda_forge_feedstock_ops/rerender.py", line 48, in rerender
    return rerender_containerized(
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/micromamba/envs/cf-scripts/lib/python3.11/site-packages/conda_forge_feedstock_ops/rerender.py", line 116, in rerender_containerized
    if data["commit_message"] is not None and data["patch"] is not None:
                                              ~~~~^^^^^^^^^
KeyError: 'patch'

However the error doesn't seem to indicate an issue with polars

Instead it leads back to the code in this repo. It looks like the line with the error was added last week with PR: #22

@jakirkham
Copy link
Member Author

cc @beckermr

@jakirkham
Copy link
Member Author

jakirkham commented Oct 24, 2024

Another failure is molmod in this job. Perhaps that is an easier case to debug

Also nnetsauce in this job

@beckermr
Copy link
Member

This has already been fixed. We're waiting for the bot to retry failures. It does this basically last.

@jakirkham
Copy link
Member Author

Where was this fixed?

@beckermr
Copy link
Member

See the discussion here: regro/cf-graph-countyfair#35

I rebuilt the container by hand to fix the issue and the sync is now working.

@beckermr
Copy link
Member

This is fixed. I moved the lock file back to cf-scripts.

@jakirkham
Copy link
Member Author

Thanks Matt! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants