feat: record errors when linting (#17)

* feat: record errors when linting

* doc: updated doc string

* chore: roll back

Author: beckermr

.github/workflows/tests.yml

@@ -27,6 +27,7 @@ jobs:
       - uses: mamba-org/setup-micromamba@f8b8a1e23a26f60a44c853292711bacfd3eac822 # v1
         with:
           environment-file: environment.yml
+          micromamba-version: "1.5.10-0"
 
       - name: configure conda and install code
         run: |

.gitignore

@@ -164,3 +164,4 @@ cython_debug/
 conda_forge_feedstock_ops/_version.py
 **/.DS_Store
 .ruff_cache/*
+.ruff_cache/

conda_forge_feedstock_ops/__main__.py

@@ -279,9 +279,9 @@ def _lint():
             "copied container feedstock dir %s: %s", fs_dir, os.listdir(fs_dir)
         )
 
-        lints, hints = lint(fs_dir, use_container=False)
+        lints, hints, errors = lint(fs_dir, use_container=False)
 
-        return {"lints": lints, "hints": hints}
+        return {"lints": lints, "hints": hints, "errors": errors}
 
 
 @click.group()

conda_forge_feedstock_ops/lint.py

@@ -37,6 +37,9 @@ def lint(feedstock_dir, use_container=None):
         Dictionary mapping relative recipe path to its lints.
     hints : dict
         Dictionary mapping relative recipe path to its hints.
+    errors : dict
+        Dictionary mapping relative recipe path to whether an error occurred
+        while linting the recipe.
     """
     if should_use_container(use_container=use_container):
         return _lint_containerized(feedstock_dir)
@@ -77,7 +80,7 @@ def _lint_containerized(feedstock_dir):
         # in the container. So we remove the subdir we made before cleaning up.
         shutil.rmtree(tmpdir)
 
-    return data["lints"], data["hints"]
+    return data["lints"], data["hints"], data["errors"]
 
 
 #############################################################
@@ -97,19 +100,27 @@ def _lint_local(feedstock_dir):
 
     lints = defaultdict(list)
     hints = defaultdict(list)
+    errors = {}
 
     for recipe in recipes:
         recipe_dir = recipe.parent
         rel_path = str(recipe.relative_to(feedstock_dir))
 
-        _lints, _hints = conda_smithy.lint_recipe.main(
-            str(recipe_dir), conda_forge=True, return_hints=True
-        )
+        try:
+            _lints, _hints = conda_smithy.lint_recipe.main(
+                str(recipe_dir), conda_forge=True, return_hints=True
+            )
+            _error = False
+        except Exception:
+            _lints = []
+            _hints = []
+            _error = True
 
         lints[rel_path] = _lints
         hints[rel_path] = _hints
+        errors[rel_path] = _error
 
-    return dict(lints), dict(hints)
+    return dict(lints), dict(hints), errors
 
 
 # end of code from conda-forge-webservices w/ modifications

tests/test_lint.py

@@ -7,28 +7,30 @@
 
 def test_lint_local():
     feedstock_dir = os.path.join(os.path.dirname(__file__), "data")
-    lints, hints = lint(
+    lints, hints, errors = lint(
         feedstock_dir,
         use_container=False,
     )
     assert len(hints) + len(lints) > 0
-    all_keys = set(lints.keys()) | set(hints.keys())
+    all_keys = set(lints.keys()) | set(hints.keys()) | set(errors.keys())
     assert all_keys == {
         "llvmdev-feedstock/recipe/meta.yaml",
         "ngmix-blah/recipe/meta.yaml",
     }
+    assert not any(err for err in errors.values())
 
 
 @skipif_no_containers
 def test_lint_container(use_containers):
     feedstock_dir = os.path.join(os.path.dirname(__file__), "data")
-    lints, hints = lint(
+    lints, hints, errors = lint(
         feedstock_dir,
         use_container=False,
     )
     assert len(hints) + len(lints) > 0
-    all_keys = set(lints.keys()) | set(hints.keys())
+    all_keys = set(lints.keys()) | set(hints.keys()) | set(errors.keys())
     assert all_keys == {
         "llvmdev-feedstock/recipe/meta.yaml",
         "ngmix-blah/recipe/meta.yaml",
     }
+    assert not any(err for err in errors.values())