Skip to content

build action fails again, for a new reason #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
durandg12 opened this issue Apr 17, 2025 · 2 comments
Open

build action fails again, for a new reason #39

durandg12 opened this issue Apr 17, 2025 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@durandg12
Copy link

Hello, yesterday I did a minor commit durandg12/algo-curve@27e53e2 on my repo, I just modified my affiliation in the yaml header, as you can see :

Image

To my surprise, the build action immediately failed, on startup, whereas on my last merges it did work :

Image

For the record, I last changed .github/workflows/build.yml in this commit durandg12/algo-curve@328fa6e from Dec 4, 2024 as a result of this comment #33 (comment) by @pneuvial.

The error is the following :

Image
 Invalid workflow file: .github/workflows/build.yml#L20
The workflow is not valid. .github/workflows/build.yml (Line: 20, Col: 20): Invalid input, config-path is not defined in the referenced workflow. .github/workflows/build.yml (Line: 18, Col: 14): Invalid secret, token is not defined in the referenced workflow.

However I see that the file https://github.com/computorg/computo-quarto-extension/blob/main/.github/workflows/build.yml has changed again recently. Do I need to update my build.yml to match?

Thanks in advance,

@fradav fradav added the documentation Improvements or additions to documentation label Apr 17, 2025
@fradav fradav self-assigned this Apr 17, 2025
@fradav
Copy link
Contributor

fradav commented Apr 17, 2025

Hi Guillermo, we changed some bits in the workflow use, and, more importantly, we completely alleviated the use of the gh-pages branch, which was causing confusion and site deployment failures.
Now the correct way is documented there
You have to put this as build.yml:

name: Main Workflows

on:
  push:
    branches: ["main","master"]
  repository_dispatch:
    types: [custom-event] 
  workflow_dispatch:
  pull_request:
    branches: ["main","master"]


jobs:
  call_env_workflow:
    uses: computorg/workflows/.github/workflows/global-env.yml@main
  call_quartopublish_workflow:
    permissions:
      id-token: write
      contents: write
      pages: write
    uses: computorg/workflows/.github/workflows/publish-render.yml@main
    needs: call_env_workflow

And to switch the deployment option to “GitHub actions” in the settings, as instructed in the new doc.

@durandg12
Copy link
Author

It worked, thank you. By the way, the figure placement on the webpage https://computo.sfds.asso.fr/blog/2025/revised-github-process/ seems wrong, there is an empty "Workflow Visualization" section after the figure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants