+ button on pending uploads screen #6327
Open
+291
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I installed your branch on my phone and will test tomorrow. :-) |
nicolas-raoul
requested changes
May 31, 2025
| @@ -115,6 +188,81 @@ class PendingUploadsFragment : | |||
| } | |||
| } | |||
|
|
|||
| private fun initializeAnimations() { | |||
There was a problem hiding this comment.
If I understand correctly, most of this code is duplicated from ContributionsListFragment.kt?
If yes, how about not duplicating it, for instance by creating an abstract base class?
|
✅ Generated APK variants! |
|
From a functional point of view it is working great! :-) |
|
Ah, just another thing to fix: After tapping + and uploading several times, I have to press "Back" many times to reach the "Contributions" screen and see the pictures I uploaded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
The button allows users to
Fixes #6278
What changes did you make and why?
Refactored PendingUploadsFragment to include the missing + button which enables users to upload Images even when current uploads are pending
Tests performed (required)
Tested ProdDebug build on a real device (Vivo T1x) running API level 30. Verified that:
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.