Skip to content

Commit c4c8241

Browse files
committed
stackage-diff: add a previous diff link
allowing navigating back to earlier consecutive diffs Arguably we could also navigate name1 and name2 separately Thanks to @chreekat for reviewing and improving the code (#340)
1 parent ec5d5e7 commit c4c8241

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

src/Handler/StackageHome.hs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ instance ToJSON SnapshotInfo where
5353
getStackageDiffR :: SnapName -> SnapName -> Handler TypedContent
5454
getStackageDiffR name1 name2 = track "Handler.StackageHome.getStackageDiffR" $ do
5555
cacheSeconds $ 60 * 60 * 48
56-
Entity sid1 _ <- lookupSnapshot name1 >>= maybe notFound return
56+
Entity sid1 prevSnap <- lookupSnapshot name1 >>= maybe notFound return
57+
mprevprevSnapName <- map snd <$> snapshotBefore (snapshotName prevSnap)
5758
Entity sid2 _ <- lookupSnapshot name2 >>= maybe notFound return
5859
snapDiff <- getSnapshotDiff sid1 sid2
5960
selectRep $ do

templates/stackage-diff.hamlet

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
<h1>Compare Stackage snapshots
22

3+
$maybe prevprev <- mprevprevSnapName
4+
<div .snapshot-nav>
5+
<a href=@{StackageDiffR prevprev name1}>
6+
\< previous diff
7+
38
<div .container .content>
49
<div .packages>
510
<table .table>

0 commit comments

Comments
 (0)