Skip to content

Commit 77fbd60

Browse files
authored
Merge pull request #393 from collective/petschki-widgetrenderer-maurits
Fix IEasyFormWidget marker for GroupForm widgets (take 2)
2 parents c33922c + 45dee4c commit 77fbd60

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

CHANGES.rst

+3
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ Changelog
3232
- Schemaeditor UI: close modals and reload fields(sets) when saving.
3333
[petschki]
3434

35+
- Fix bug which did not render correctly GroupForm widgets (see #370)
36+
[petschki]
37+
3538

3639
4.1.0 (2022-08-10)
3740
------------------

setup.py

+1
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
"plone.schema",
4949
"plone.schemaeditor>=4.0.0b1",
5050
"plone.supermodel",
51+
"plone.restapi",
5152
"Products.CMFPlone>=6.0.0b1",
5253
"Products.validation",
5354
"setuptools",

src/collective/easyform/browser/view.py

+6-3
Original file line numberDiff line numberDiff line change
@@ -300,12 +300,14 @@ def updateActions(self):
300300
if "reset" in self.actions:
301301
self.actions["reset"].title = self.context.resetLabel
302302

303-
def updateWidgets(self):
304-
super(EasyFormForm, self).updateWidgets()
303+
def markWidgets(self):
305304
for w in self.widgets.values():
306305
if not IEasyFormWidget.providedBy(w):
307-
# add marker for custom widget renderer
308306
alsoProvides(w, IEasyFormWidget)
307+
for g in self.groups:
308+
for w in g.widgets.values():
309+
if not IEasyFormWidget.providedBy(w):
310+
alsoProvides(w, IEasyFormWidget)
309311

310312
def formMaybeForceSSL(self):
311313
"""Redirect to an https:// URL if the 'force SSL' option is on.
@@ -328,6 +330,7 @@ def update(self):
328330
"""Update form - see interfaces.IForm"""
329331
self.formMaybeForceSSL()
330332
super(EasyFormForm, self).update()
333+
self.markWidgets()
331334
self.template = self.form_template
332335
if self.request.method != "POST" or self.context.thanksPageOverride:
333336
# go with all but default thank you page rendering

0 commit comments

Comments
 (0)