Skip to content

Commit d958b45

Browse files
adam-browningstsepelin
authored andcommitted
oneVideo Bid Adapter: remove adapter adId because of conflict with pbjs core (prebid#6382)
* updated object,str,num validations using pbjs utils * validation if statements for content object * validation if statements for content object * updated contetn object validations using utils * refractoring clean if statement * fixing typos * added todos * added category string & data object validations * fixed esling ENDPOINT issue * updated content obj unit tests * fixed cat & data validation * fixed producer as object * revert .includes() to .indexof() for IE * reduced content obj params accoriding to ad-server support * fixed typeOf typo * fixed episode to Number * gitignore * restore gitignore * removed unsupported params from md file * reverted package & pagkage-lock * fixed incorrect episdoe from str to num * removed bid.adid setting from L97 * removed bid.adId setting * updated adId test * updated version to 3.0.6
1 parent 6fbc3f9 commit d958b45

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

modules/oneVideoBidAdapter.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {registerBidder} from '../src/adapters/bidderFactory.js';
44
const BIDDER_CODE = 'oneVideo';
55
export const spec = {
66
code: 'oneVideo',
7-
VERSION: '3.0.5',
7+
VERSION: '3.0.6',
88
ENDPOINT: 'https://ads.adaptv.advertising.com/rtb/openrtb?ext_id=',
99
E2ETESTENDPOINT: 'https://ads-wc.v.ssp.yahoo.com/rtb/openrtb?ext_id=',
1010
SYNC_ENDPOINT1: 'https://pixel.advertising.com/ups/57304/sync?gdpr=&gdpr_consent=&_origin=0&redir=true',
@@ -94,7 +94,6 @@ export const spec = {
9494
requestId: bidRequest.bidId,
9595
bidderCode: spec.code,
9696
cpm: bid.price,
97-
adId: bid.adid,
9897
creativeId: bid.crid,
9998
width: size.width,
10099
height: size.height,

test/spec/modules/oneVideoBidAdapter_spec.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ describe('OneVideoBidAdapter', function () {
221221
const placement = bidRequest.params.video.placement;
222222
const rewarded = bidRequest.params.video.rewarded;
223223
const inventoryid = bidRequest.params.video.inventoryid;
224-
const VERSION = '3.0.5';
224+
const VERSION = '3.0.6';
225225
expect(data.imp[0].video.w).to.equal(width);
226226
expect(data.imp[0].video.h).to.equal(height);
227227
expect(data.imp[0].bidfloor).to.equal(bidRequest.params.bidfloor);
@@ -567,7 +567,6 @@ describe('OneVideoBidAdapter', function () {
567567
requestId: bidRequest.bidId,
568568
bidderCode: spec.code,
569569
cpm: serverResponse.seatbid[0].bid[0].price,
570-
adId: serverResponse.seatbid[0].bid[0].adid,
571570
creativeId: serverResponse.seatbid[0].bid[0].crid,
572571
vastXml: serverResponse.seatbid[0].bid[0].adm,
573572
width: 640,

0 commit comments

Comments
 (0)