Skip to content

Upload script confused if Python coverage data is not in $git_root #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkloetzke opened this issue Jun 18, 2021 · 1 comment
Closed

Comments

@jkloetzke
Copy link

I encountered a problem that the upload always failed for me with no real error message. The trigger turned out to be uncombined coverage data in some sub-directory of a Python project. The current upload script will cd to the last found directory holding a .coverage* file, call coverage combine -a and then try to cd back. But because $proj_root is a relative directory this will fail. Somewhere later in the script git ls-files is called but then in the wrong directory leading to the subsequent failure. See here for an example: https://github.com/BobBuildTool/bob/runs/2852901363#step:8:224

I think the script should better use pushd and popd. That should be safe.

BTW, while reading the script I saw that it cannot handle coverage data in multiple directories. Is this intentional?

@thomasrockhu-codecov
Copy link
Contributor

I blive the answer should be to run coverage xml after this. If you are still experiencing an issue @jkloetzke, please open a community ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants