Skip to content

Commit 6e2fdc7

Browse files
authored
[chore] Remove unused GH env var from makefile (open-telemetry#9033)
The env var is not being used. `gh` command is used directly in the shell scripts, not make targets.
1 parent f33a65a commit 6e2fdc7

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

.github/workflows/scripts/release-prepare-release.sh

+4-4
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,14 @@ git add --all
2626
git commit -m "Changelog update ${RELEASE_VERSION}"
2727

2828
if [ "${CANDIDATE_STABLE}" != "" ]; then
29-
make prepare-release GH=none PREVIOUS_VERSION="${CURRENT_STABLE}" RELEASE_CANDIDATE="${CANDIDATE_STABLE}" MODSET=stable
29+
make prepare-release PREVIOUS_VERSION="${CURRENT_STABLE}" RELEASE_CANDIDATE="${CANDIDATE_STABLE}" MODSET=stable
3030
COMMANDS+="
31-
- make prepare-release GH=none PREVIOUS_VERSION=${CURRENT_STABLE} RELEASE_CANDIDATE=${CANDIDATE_STABLE} MODSET=stable"
31+
- make prepare-release PREVIOUS_VERSION=${CURRENT_STABLE} RELEASE_CANDIDATE=${CANDIDATE_STABLE} MODSET=stable"
3232
fi
3333
if [ "${CANDIDATE_BETA}" != "" ]; then
34-
make prepare-release GH=none PREVIOUS_VERSION="${CURRENT_BETA}" RELEASE_CANDIDATE="${CANDIDATE_BETA}" MODSET=beta
34+
make prepare-release PREVIOUS_VERSION="${CURRENT_BETA}" RELEASE_CANDIDATE="${CANDIDATE_BETA}" MODSET=beta
3535
COMMANDS+="
36-
- make prepare-release GH=none PREVIOUS_VERSION=${CURRENT_BETA} RELEASE_CANDIDATE=${CANDIDATE_BETA} MODSET=beta"
36+
- make prepare-release PREVIOUS_VERSION=${CURRENT_BETA} RELEASE_CANDIDATE=${CANDIDATE_BETA} MODSET=beta"
3737
fi
3838
git push origin "${BRANCH}"
3939

Makefile.Common

-2
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ MULTIMOD := $(TOOLS_BIN_DIR)/multimod
3333
PORTO := $(TOOLS_BIN_DIR)/porto
3434
YQ := $(TOOLS_BIN_DIR)/yq
3535

36-
GH := $(shell which gh)
37-
3836
.PHONY: install-tools
3937
install-tools: $(TOOLS_BIN_NAMES) $(YQ)
4038

0 commit comments

Comments
 (0)