-
Notifications
You must be signed in to change notification settings - Fork 15
feat(examples-plugins): add package-json plugin 📦 #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@matejchalk the currently failing 'CI / Code PushUp (push) ' job may be due to server bug in scoring logic. I DMed you. |
@BioPhoton did the discussion we had on "it's 100 not 0" yesterday help to unblock the failing problem or is it still a blocker? |
Well I guess it is also a change for the backend no? |
Maybe, depends on what the agreement is. Our last chat was inconclusive.
|
added a weight for now |
@matejchalk I implemented a solution for "empty" category refs. It will get validated by the model now and throws in both cases. the schema and the scoring logic. How should we deal with groups? Here I'm not sure. |
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
….audit.ts Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
….audit.ts Co-authored-by: Matěj Chalk <[email protected]>
…t.ts Co-authored-by: Matěj Chalk <[email protected]>
…t.unit.test.ts Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
@matejchalk I resolved all comments. Thanks a lot for the review. I also added more tests for the Last thing would be this: #354 (comment) |
This PR includes:
Additional changes:
CategoryConfig
. Now it throws for empty refsCategoryRef
. Now min length 1plugin-eslint
exports