Skip to content

Commit be7471e

Browse files
authored
fix(utils,cli): remove all mentions of the interactive option (#245)
Close #120
1 parent 84b8c28 commit be7471e

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

packages/cli/src/lib/implementation/model.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Format, GlobalOptions } from '@code-pushup/models';
22

3-
// type GeneralCliOnlyOptions = { progress: boolean }; // @TODO consider interactive and progress as CLI only options
3+
// type GeneralCliOnlyOptions = { progress: boolean }; // @TODO consider progress as CLI only options
44
export type GeneralCliOptions = GlobalOptions;
55

66
export type CoreConfigCliOptions = {

packages/utils/src/lib/execute-process.spec.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -86,15 +86,15 @@ describe('objectToCliArgs', () => {
8686
});
8787

8888
it('should handle boolean arguments', () => {
89-
const params = { interactive: true };
89+
const params = { progress: true };
9090
const result = objectToCliArgs(params);
91-
expect(result).toEqual(['--interactive']);
91+
expect(result).toEqual(['--progress']);
9292
});
9393

9494
it('should handle negated boolean arguments', () => {
95-
const params = { interactive: false };
95+
const params = { progress: false };
9696
const result = objectToCliArgs(params);
97-
expect(result).toEqual(['--no-interactive']);
97+
expect(result).toEqual(['--no-progress']);
9898
});
9999

100100
it('should handle array of string arguments', () => {

packages/utils/src/lib/execute-process.ts

-1
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ export type CliArgsObject<T extends object = Record<string, ArgumentValue>> =
182182
* const args = objectToProcessArgs({
183183
* _: ['node', 'index.js'], // node index.js
184184
* name: 'Juanita', // --name=Juanita
185-
* interactive: false, // --no-interactive
186185
* formats: ['json', 'md'] // --format=json --format=md
187186
* });
188187
*/

0 commit comments

Comments
 (0)