Skip to content

Commit 39a7d43

Browse files
committed
fix(plugin-eslint): handle implicitly relative config paths
1 parent e6f6fc8 commit 39a7d43

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

packages/plugin-eslint/src/lib/eslint-plugin.spec.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,6 @@ describe('eslintPlugin', () => {
6969
it("should throw if eslintrc file doesn't exist", async () => {
7070
await expect(
7171
eslintPlugin({ eslintrc: '.eslintrc.yml', patterns: '**/*.js' }),
72-
).rejects.toThrowError(
73-
'Failed to load config ".eslintrc.yml" to extend from',
74-
);
72+
).rejects.toThrowError('Cannot read config file');
7573
});
7674
});

packages/plugin-eslint/src/lib/eslint-plugin.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ export async function eslintPlugin(
3333
const { eslintrc, patterns } = eslintPluginConfigSchema.parse(config);
3434

3535
const eslint = new ESLint({
36+
overrideConfigFile: eslintrc,
3637
useEslintrc: false,
37-
baseConfig: { extends: eslintrc },
3838
});
3939

4040
const { audits, groups } = await listAuditsAndGroups(eslint, patterns);

packages/plugin-eslint/src/lib/runner/lint.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,8 @@ describe('lint', () => {
8787
it('should correctly use ESLint Node API', async () => {
8888
await lint('.eslintrc.js', ['**/*.js']);
8989
expect(ESLint).toHaveBeenCalledWith({
90+
overrideConfigFile: '.eslintrc.js',
9091
useEslintrc: false,
91-
baseConfig: { extends: '.eslintrc.js' },
9292
});
9393
expect(eslint.lintFiles).toHaveBeenCalledTimes(1);
9494
expect(eslint.lintFiles).toHaveBeenCalledWith(['**/*.js']);

packages/plugin-eslint/src/lib/runner/lint.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ export async function lint(
77
patterns: string[],
88
): Promise<LinterOutput> {
99
const eslint = new ESLint({
10+
overrideConfigFile: eslintrc,
1011
useEslintrc: false,
11-
baseConfig: { extends: eslintrc },
1212
});
1313

1414
const lintResults = await eslint.lintFiles(patterns);

0 commit comments

Comments
 (0)