microsoft#141054 check line numbers in settigns file

Author: sandy081

automation/src/settings.ts

@@ -15,8 +15,7 @@ export class SettingsEditor {
 	constructor(private code: Code, private userDataPath: string, private editors: Editors, private editor: Editor, private quickaccess: QuickAccess) { }
 
 	async addUserSetting(setting: string, value: string): Promise<void> {
-		await this.openSettings();
-		await this.editor.waitForEditorFocus('settings.json', 1);
+		await this.openUserSettingsFile();
 
 		await this.code.dispatchKeybinding('right');
 		await this.editor.waitForTypeInEditor('settings.json', `"${setting}": ${value},`);
@@ -27,11 +26,12 @@ export class SettingsEditor {
 		const settingsPath = path.join(this.userDataPath, 'User', 'settings.json');
 		await new Promise<void>((c, e) => fs.writeFile(settingsPath, '{\n}', 'utf8', err => err ? e(err) : c()));
 
-		await this.openSettings();
+		await this.openUserSettingsFile();
 		await this.editor.waitForEditorContents('settings.json', c => c === '{}');
 	}
 
-	private async openSettings(): Promise<void> {
+	async openUserSettingsFile(): Promise<void> {
 		await this.quickaccess.runCommand('workbench.action.openSettingsJson');
+		await this.editor.waitForEditorFocus('settings.json', 1);
 	}
 }

smoke/src/areas/preferences/preferences.test.ts

@@ -19,7 +19,7 @@ export function setup(logger: Logger) {
 			await app.code.waitForElements('.line-numbers', false, elements => !!elements.length);
 
 			await app.workbench.settingsEditor.addUserSetting('editor.lineNumbers', '"off"');
-			await app.workbench.editors.selectTab('app.js');
+			await app.workbench.settingsEditor.openUserSettingsFile();
 			await app.code.waitForElements('.line-numbers', false, result => !result || result.length === 0);
 		});