Don't lose HDR's errors.

codahale · codahale · commit 58a3f5df7e15 · 2014-08-23T11:51:11.000-07:00
diff --git a/metrics.go b/metrics.go
@@ -135,12 +135,13 @@ type Histogram struct {
 	rw   sync.RWMutex
 }
 
-// RecordValue records the given value.
-func (h *Histogram) RecordValue(v int64) {
+// RecordValue records the given value, or returns an error if the value is out
+// of range.
+func (h *Histogram) RecordValue(v int64) error {
 	h.rw.Lock()
 	defer h.rw.Unlock()
 
-	h.hist.Current.RecordValue(v)
+	return h.hist.Current.RecordValue(v)
 }
 
 func (h *Histogram) rotate() {

Original file line number	Diff line number	Diff line change
`@@ -135,12 +135,13 @@ type Histogram struct {`
`135`	`135`	`rw sync.RWMutex`
`136`	`136`	`}`
`137`	`137`
`138`		`-// RecordValue records the given value.`
`139`		`-func (h *Histogram) RecordValue(v int64) {`
	`138`	`+// RecordValue records the given value, or returns an error if the value is out`
	`139`	`+// of range.`
	`140`	`+func (h *Histogram) RecordValue(v int64) error {`
`140`	`141`	`h.rw.Lock()`
`141`	`142`	`defer h.rw.Unlock()`
`142`	`143`
`143`		`- h.hist.Current.RecordValue(v)`
	`144`	`+ return h.hist.Current.RecordValue(v)`
`144`	`145`	`}`
`145`	`146`
`146`	`147`	`func (h *Histogram) rotate() {`