release: v1.0.5

Author: cocowalla

CommonAssemblyInfo.cs

@@ -9,6 +9,6 @@
 [assembly: ComVisible(false)]
 
 [assembly: AssemblyVersion("1.0.0.0")]
-[assembly: AssemblyInformationalVersion("1.0.4")]
+[assembly: AssemblyInformationalVersion("1.0.5")]
 
 [assembly: System.Runtime.CompilerServices.InternalsVisibleTo("Serilog.Sinks.File.Archive.Tests, PublicKey=002400000480000094000000060200000024000052534131000400000100010025498721eb03bb1731fc4b9646dba1ccf8b4200219d34d57cd538162531409077fdfeead7efbeef28c352fa5e08e2010f2bfe3ae75d7a18a736b5a9c075ba69f0d8da5bfab51b53e23b9214eb8957e992dd31ed94d49ba8d6cc72cf79c06e1085a43559b9644a4b7d621c2d64baf6cc2edc2ae754a0f8f77faccb71cbb1d22df")]

src/Serilog.Sinks.File.Archive/ArchiveHooks.cs

@@ -98,7 +98,8 @@ public override void OnFileDeleting(string path)
                         sourceStream.CopyTo(compressStream);
                     }
                 }
-                //only apply archive file limit if we are archiving to a non tokenised path (constant path)
+
+                // Only apply archive file limit if we are archiving to a non-tokenised path (a constant path)
                 if (this.retainedFileCountLimit > 0 && !this.IsArchivePathTokenised)
                 {
                     RemoveExcessFiles(currentTargetDir);
@@ -124,6 +125,7 @@ private void RemoveExcessFiles(string folder)
                 .OrderByDescending(f => f, LogFileComparer.Default)
                 .Skip(this.retainedFileCountLimit)
                 .ToList();
+
             foreach (var file in filesToDelete)
             {
                 try
@@ -141,9 +143,9 @@ private class LogFileComparer : IComparer<FileInfo>
         {
             public static IComparer<FileInfo> Default = new LogFileComparer();
 
-            //This will not work correctly when the file uses a date format where lexicographical order does not correspond to chronological order but frankly, if you
-            //are using non ISO 8601 date formats in your files you should be shot.
-            //It would be best if the file sink could expose a way to sort files chronologically because I think LastWriteTime is probably not determisitic enough.
+            // This will not work correctly when the file uses a date format where lexicographical order does not 
+            // correspond to chronological order - but frankly, if you are using non ISO 8601 date formats in your 
+            // files you should be shot :)
             public int Compare(FileInfo x, FileInfo y)
             {
                 if (x is null && y is null)
@@ -152,7 +154,8 @@ public int Compare(FileInfo x, FileInfo y)
                     return -1;
                 if (y is null)
                     return 1;
-                return string.Compare(x.Name, y.Name, StringComparison.OrdinalIgnoreCase);
+
+                return String.Compare(x.Name, y.Name, StringComparison.OrdinalIgnoreCase);
             }
         }
     }

src/Serilog.Sinks.File.Archive/Serilog.Sinks.File.Archive.csproj

@@ -2,7 +2,7 @@
 
     <PropertyGroup>
         <Description>Plugin for the Serilog File sink that archives completed log files, optionally compressing them.</Description>
-        <VersionPrefix>1.0.4</VersionPrefix>
+        <VersionPrefix>1.0.5</VersionPrefix>
         <GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
         <Authors>Colin Anderson</Authors>
         <Copyright>Copyright © Colin Anderson 2020</Copyright>

test/Serilog.Sinks.File.Archive.Test/Serilog.Sinks.File.Archive.Test.csproj

@@ -9,10 +9,12 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
+        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
+        <PackageReference Include="xunit" Version="2.7.0" />
+        <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3" />
+
+        <!-- newer versions no longer support net45 -->
         <PackageReference Include="Shouldly" Version="4.0.0-beta0002" />
-        <PackageReference Include="xunit" Version="2.4.1" />
-        <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" />
     </ItemGroup>
 
     <ItemGroup>