Skip to content

Combined standalone subroutine + module in same file is crashing scanner in FORTRAN file #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arthurvd opened this issue Oct 17, 2019 · 2 comments · Fixed by #190 or #191
Closed
Assignees
Labels
Milestone

Comments

@arthurvd
Copy link

Expected behavior

A FORTRAN source file may contain modules and 'standalone' subroutine's in one and the same file.

Actual behavior

For the attached source file, we have a module m_fm_morstatistics, followed by subroutine sedmor_write_stats() in one file fm_morstatistics.f90:
fm_morstatistics.f90.txt

The scanner crashes on it.
1571146357496.log

result.xml.txt

Steps to reproduce behavior

icode.exe dflowfm_conv/**/* -o Results/results.xml

Detection version

3.1.0

@begarco
Copy link
Contributor

begarco commented Jan 7, 2020

Not reproduced on i-Code 4. Please use i-Code 4.0 when released.

@begarco begarco added this to the Version 4.0.0 milestone Jan 7, 2020
@arthurvd
Copy link
Author

arthurvd commented Jan 8, 2020

Thank you, we'll do that.

This was referenced Feb 9, 2020
@begarco begarco mentioned this issue Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants