Fix empty alarm actions (#38)

aclemmensen · web-flow · commit 48f08572a659 · 2024-09-19T14:01:30.000+01:00
diff --git a/main.tf b/main.tf
@@ -14,10 +14,10 @@ resource "aws_cloudwatch_metric_alarm" "cpu_high" {
     ClusterName = var.ecs_cluster_name
     ServiceName = var.ecs_service_name
   }
-  alarm_actions = [
+  alarm_actions = compact([
     aws_appautoscaling_policy.scale_up_policy.arn,
     var.sns_topic_arn != "" ? var.sns_topic_arn : ""
-  ]
+  ])
   tags = var.tags
 }
 
@@ -37,10 +37,10 @@ resource "aws_cloudwatch_metric_alarm" "cpu_low" {
     ClusterName = var.ecs_cluster_name
     ServiceName = var.ecs_service_name
   }
-  alarm_actions = [
+  alarm_actions = compact([
     aws_appautoscaling_policy.scale_down_policy.arn,
     var.sns_topic_arn != "" ? var.sns_topic_arn : ""
-  ]
+  ])
   tags = var.tags
 }
 

Original file line number	Diff line number	Diff line change
`@@ -14,10 +14,10 @@ resource "aws_cloudwatch_metric_alarm" "cpu_high" {`
`14`	`14`	`ClusterName = var.ecs_cluster_name`
`15`	`15`	`ServiceName = var.ecs_service_name`
`16`	`16`	`}`
`17`		`- alarm_actions = [`
	`17`	`+ alarm_actions = compact([`
`18`	`18`	`aws_appautoscaling_policy.scale_up_policy.arn,`
`19`	`19`	`var.sns_topic_arn != "" ? var.sns_topic_arn : ""`
`20`		`- ]`
	`20`	`+ ])`
`21`	`21`	`tags = var.tags`
`22`	`22`	`}`
`23`	`23`
`@@ -37,10 +37,10 @@ resource "aws_cloudwatch_metric_alarm" "cpu_low" {`
`37`	`37`	`ClusterName = var.ecs_cluster_name`
`38`	`38`	`ServiceName = var.ecs_service_name`
`39`	`39`	`}`
`40`		`- alarm_actions = [`
	`40`	`+ alarm_actions = compact([`
`41`	`41`	`aws_appautoscaling_policy.scale_down_policy.arn,`
`42`	`42`	`var.sns_topic_arn != "" ? var.sns_topic_arn : ""`
`43`		`- ]`
	`43`	`+ ])`
`44`	`44`	`tags = var.tags`
`45`	`45`	`}`
`46`	`46`