Fixing errors on module

Author: jnonino

main.tf

@@ -6,6 +6,17 @@ provider "aws" {
   region  = var.region
 }
 
+# ---------------------------------------------------------------------------------------------------------------------
+# S3 BUCKET - For access logs
+# ---------------------------------------------------------------------------------------------------------------------
+# resource "aws_s3_bucket" "logs" {
+#   bucket = "${var.name_preffix}-lb-logs"
+#   region = var.region
+#   tags = {
+#     Name = "${var.name_preffix}-lb-logs"
+#   }
+# }
+
 # ---------------------------------------------------------------------------------------------------------------------
 # APPLICATION LOAD BALANCER
 # ---------------------------------------------------------------------------------------------------------------------
@@ -20,17 +31,15 @@ resource "aws_lb" "lb" {
   enable_cross_zone_load_balancing = var.enable_cross_zone_load_balancing
   enable_http2                     = var.enable_http2
   ip_address_type                  = var.ip_address_type
-  security_groups    = compact(
+  security_groups                  = compact(
     concat(var.security_groups, [aws_security_group.lb_access_sg.id]),
   )
-  dynamic "access_logs" {
-    for_each = var.access_logs == null ? [] : [var.access_logs]
-    content {
-      bucket  = access_logs.value.bucket
-      prefix  = access_logs.value.prefix
-      enabled = access_logs.value.enabled
-    }
-  }
+  # TODO - Enable this feature
+  # access_logs {
+  #   bucket  = aws_s3_bucket.logs.id
+  #   prefix  = ""
+  #   enabled = true
+  # }
   tags = {
     Name = "${var.name_preffix}-lb"
   }
@@ -91,8 +100,8 @@ resource "aws_lb_target_group" "lb_http_tgs" {
   dynamic "stickiness" {
     for_each = var.stickiness == null ? [] : [var.stickiness]
     content {
-      type            = stickiness.value.bucket
-      cookie_duration = stickiness.value.prefix
+      type            = stickiness.value.type
+      cookie_duration = stickiness.value.cookie_duration
       enabled         = stickiness.value.enabled
     }
   }

outputs.tf

@@ -31,96 +31,96 @@ output "aws_lb_lb_zone_id" {
 # ---------------------------------------------------------------------------------------------------------------------
 output "aws_security_group_lb_access_sg_id" {
   description = "The ID of the security group"
-  value = aws_security_group.lb_access_sg.id
+  value       = aws_security_group.lb_access_sg.id
 }
 
 output "aws_security_group_lb_access_sg_arn" {
   description = "The ARN of the security group"
-  value = aws_security_group.lb_access_sg.arn
+  value       = aws_security_group.lb_access_sg.arn
 }
 
 output "aws_security_group_lb_access_sg_vpc_id" {
   description = "The VPC ID."
-  value = aws_security_group.lb_access_sg.vpc_id
+  value       = aws_security_group.lb_access_sg.vpc_id
 }
 
 output "aws_security_group_lb_access_sg_owner_id" {
   description = "The owner ID."
-  value = aws_security_group.lb_access_sg.owner_id
+  value       = aws_security_group.lb_access_sg.owner_id
 }
 
 output "aws_security_group_lb_access_sg_name" {
   description = "The name of the security group"
-  value = aws_security_group.lb_access_sg.name
+  value       = aws_security_group.lb_access_sg.name
 }
 
 output "aws_security_group_lb_access_sg_description" {
   description = "The description of the security group"
-  value = aws_security_group.lb_access_sg.description
+  value       = aws_security_group.lb_access_sg.description
 }
 
 output "aws_security_group_lb_access_sg_ingress" {
   description = "The ingress rules."
-  value = aws_security_group.lb_access_sg.ingress
+  value       = aws_security_group.lb_access_sg.ingress
 }
 
 output "aws_security_group_lb_access_sg_egress" {
   description = "The egress rules."
-  value = aws_security_group.lb_access_sg.egress
+  value       = aws_security_group.lb_access_sg.egress
 }
 
 # ---------------------------------------------------------------------------------------------------------------------
 # AWS LOAD BALANCER - Target Groups
 # ---------------------------------------------------------------------------------------------------------------------
 output "lb_http_tgs_ids" {
   description = "List of HTTP Target Groups IDs"
-  value = ["${aws_lb_target_group.lb_http_tgs.*.id}"]
+  value       = ["${aws_lb_target_group.lb_http_tgs.*.id}"]
 }
 
 output "lb_http_tgs_arns" {
   description = "List of HTTP Target Groups ARNs"
-  value = ["${aws_lb_target_group.lb_http_tgs.*.arn}"]
+  value       = ["${aws_lb_target_group.lb_http_tgs.*.arn}"]
 }
 
 output "lb_http_tgs_names" {
   description = "List of HTTP Target Groups Names"
-  value = ["${aws_lb_target_group.lb_http_tgs.*.name}"]
+  value       = ["${aws_lb_target_group.lb_http_tgs.*.name}"]
 }
 
 output "lb_https_tgs_ids" {
   description = "List of HTTPS Target Groups IDs"
-  value = ["${aws_lb_target_group.lb_https_tgs.*.id}"]
+  value       = ["${aws_lb_target_group.lb_https_tgs.*.id}"]
 }
 
 output "lb_https_tgs_arns" {
   description = "List of HTTPS Target Groups ARNs"
-  value = ["${aws_lb_target_group.lb_https_tgs.*.arn}"]
+  value       = ["${aws_lb_target_group.lb_https_tgs.*.arn}"]
 }
 
 output "lb_https_tgs_names" {
   description = "List of HTTPS Target Groups Names"
-  value = ["${aws_lb_target_group.lb_https_tgs.*.name}"]
+  value       = ["${aws_lb_target_group.lb_https_tgs.*.name}"]
 }
 
 # ---------------------------------------------------------------------------------------------------------------------
 # AWS LOAD BALANCER - Listeners
 # ---------------------------------------------------------------------------------------------------------------------
 output "lb_http_listeners_ids" {
   description = "List of HTTP Listeners IDs"
-  value = ["${aws_lb_listener.lb_http_listeners.*.id}"]
+  value       = ["${aws_lb_listener.lb_http_listeners.*.id}"]
 }
 
 output "lb_http_listeners_arns" {
   description = "List of HTTP Listeners ARNs"
-  value = ["${aws_lb_listener.lb_http_listeners.*.arn}"]
+  value       = ["${aws_lb_listener.lb_http_listeners.*.arn}"]
 }
 
 output "lb_https_listeners_ids" {
   description = "List of HTTPS Listeners IDs"
-  value = ["${aws_lb_listener.lb_https_listeners.*.id}"]
+  value       = ["${aws_lb_listener.lb_https_listeners.*.id}"]
 }
 
 output "lb_https_listeners_arns" {
   description = "List of HTTPS Listeners ARNs"
-  value = ["${aws_lb_listener.lb_https_listeners.*.arn}"]
-}
+  value       = ["${aws_lb_listener.lb_https_listeners.*.arn}"]
+}

variables.tf

@@ -44,16 +44,6 @@ variable "drop_invalid_header_fields" {
   default     = false
 }
 
-variable "access_logs" {
-  description = "(Optional) An Access Logs block. Provide three fields. bucket, the S3 bucket name to store the logs in. prefix, the S3 bucket prefix. enabled, boolean to enable / disable access_logs."
-  type = object({
-    bucket  = string
-    prefix  = string
-    enabled = bool
-  })
-  default     = null
-}
-
 variable "private_subnets" {
   description = "A list of private subnet IDs to attach to the LB if it is INTERNAL."
   type        = list(string)
@@ -196,6 +186,7 @@ variable "target_group_health_check_interval" {
 variable "target_group_health_check_path" {
   description = "The destination for the health check request."
   type        = string
+  default     = "/"
 }
 
 variable "target_group_health_check_timeout" {