fix: version pin to avoid hashicorp/aws provider bug #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent is to avoid 5.86.0. Github issue detailing bug, hashicorp/terraform-provider-aws#41296
|
This may not be an issue any longer. Usually the cp modules don't pin an upperbound since the module caller has the ability to pin in their versions.tf file so this gives people flexibility. By pinning the upperbound, we lose that and for that reason we need to close this PR. Sorry about that. Please send more PRs and we will review when time permits. Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
hasicorp/awsprovider version.why
v5.86.0release, which moved from the Terraform Plugin SDK to Terraform Plugin Framework.v5.86.0code changes the default lifecycle value and going forward requires that you use a 5.86.0 or greater provider.references